setConfiguration({ peerIdentity }) when there is no initial peerIdentity #1464
Conversation
|
This removes the original condition. Does this means peerIdentity can be changed if it is initially set? |
|
@soareschen Restored the original condition. |
|
This would be a fine answer to the question. Note that you could take the approach I stated earlier, but that's more complicated. |
webrtc.html
Outdated
| @@ -1679,9 +1679,6 @@ | |||
| set and <a>[[\Configuration]]</a>.<code>peerIdentity</code> is | |||
| not set, <a>throw</a> an <code>InvalidModificationError</code>. | |||
| </li> | |||
| <li>If <code><var>configuration</var>.peerIdentity</code> is | |||
There was a problem hiding this comment.
Is the original condition removed again?
| set and its value differs from the <a>target peer | ||
| identity</a>, <a>throw</a> an <code>InvalidModificationError</code>. | ||
| set and <a>[[\Configuration]]</a>.<code>peerIdentity</code> is | ||
| not set, <a>throw</a> an <code>InvalidModificationError</code>. |
There was a problem hiding this comment.
This sounds like it allows the peer identity to change, just not go from being unset to being set. I don't think that's what we want. I thought the plan was to give everything a default value (null for peerIdentity, [] for certificates, etc.), and just say "if the value is different, throw an InvalidModificationError".
Fix for Issue #1456
Preview | Diff