Adding relativeBitrate parameter to RTCRtpEncodingParameters. #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes w3c#1625. This provides more fine-grained control over the relative amount of bits different encodings should be allocated. This allows the webrtc implementation to respond quickly to changes in available capacity; the alternative would be for an application to inspect the stats periodically, and continually adjust `maxBitrate`, which would result in wasted bandwidth and slower responsiveness to changing bandwidth estimates (since polling stats and calling getParameters/setParameters is not instantaneous). This assumes that rtcweb-transports will update its definition of "priority," such that it only controls the priority of streams in network queues (via DSCP and SCTP priority values), and not the relative amount of bitrate they're granted.
|
I think it would be premature to merge this one now. Perhaps a discussion at TPAC? |
fluffy
approved these changes
Nov 2, 2017
|
Discussion at TPAC suggested heading in a different direction. |
|
Looks like this PR is (to be) replaced by https://github.com/alvestrand/webrtc-dscp-exp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1625.
This provides more fine-grained control over the relative amount of bits
different encodings should be allocated. This allows the webrtc
implementation to respond quickly to changes in available capacity; the
alternative would be for an application to inspect the stats
periodically, and continually adjust
maxBitrate, which would result inwasted bandwidth and slower responsiveness to changing bandwidth
estimates (since polling stats and calling getParameters/setParameters
is not instantaneous).
This assumes that rtcweb-transports will update its definition of
"priority," such that it only controls the priority of streams in
network queues (via DSCP and SCTP priority values), and not the
relative amount of bitrate they're granted.
Preview | Diff