Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that "disconnected" is transient (editorial) #1741

Merged
merged 3 commits into from
Jan 25, 2018
Merged

Clarify that "disconnected" is transient (editorial) #1741

merged 3 commits into from
Jan 25, 2018

Conversation

jan-ivar
Copy link
Member

Fix for #1740.

aboba
aboba reviewed Jan 22, 2018
View reviewed changes
Copy link
Contributor

@aboba aboba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think “aggressive” may mean to imply something about how an application might respond to the transient indication. Problem is that implementations vary so it might be best ignored in some cases but not in others.

fluffy
fluffy approved these changes Jan 24, 2018
View reviewed changes
Copy link
Contributor

@fluffy fluffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems totally editorial and I'm not sure it really improves things too much. I certainly have no objections to it but I do wonder at what point we want to try and stop making changes that are not critical to make.

@alvestrand alvestrand merged commit 1f552e9 into w3c:master Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aboba aboba aboba left review comments

@fluffy fluffy fluffy approved these changes

@alvestrand alvestrand alvestrand approved these changes

@burnburn burnburn burnburn approved these changes

@stefhak stefhak stefhak approved these changes

@taylor-b taylor-b taylor-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jan-ivar @fluffy @alvestrand @aboba @burnburn @stefhak @taylor-b