Buffered amount slot #1794
Merged
Buffered amount slot #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This still needs to decrement Similar to with |
|
Should address decrementing the counter before submitting. Otherwise seems fine. |
adam-be
force-pushed
the
buffered-amount-slot
branch
from
41b768c
to
559e5c8
Compare
adam-be
commented
Mar 15, 2018
| <a>underlying data transport</a> sends data from its queue, the | ||
| user agent MUST queue a task that reduces | ||
| <a>[[\BufferedAmount]]</a> with the number of bytes that was | ||
| sent.</p> |
There was a problem hiding this comment.
With this text I guess we leave it up to implementations to decide how often to update the slot.
aboba
approved these changes
Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1792
Preview | Diff