Update mandatory to implement stats #1803
Conversation
|
LGTM. |
| @@ -9942,14 +9942,14 @@ <h3>Mandatory To Implement Stats</h3> | |||
| inherited dictionaries, and also attributes packetsReceived, | |||
There was a problem hiding this comment.
Above this point: RTCRTPStreamStats mediaType has been renamed to kind
RTCRTPStreamStats.trackId has moved to RTCInboundRtpStreamStats and RTCOutboundRtpStreamStats
RTCReceivedRTPStreamStats doesn't have bytesReceived - it's moved to RTCInboundRtpStreamStats
webrtc.html
Outdated
| <li>RTCRemoteInboundRTPStreamStats, with all required attributes from | ||
| its inherited dictionaries, and also attributes localId, | ||
| roundTripTime</li> | ||
| <li>RTCSentRTPStreamStats, with all required attributes from its | ||
| inherited dictionaries, and also attributes packetsSent, bytesSent</li> | ||
| <li>RTCOutboundRTPStreamStats, with all required attributes from its | ||
| inherited dictionaries, and also attributes remoteId, framesEncoded</li> | ||
| inherited dictionaries, and also attributes senderId, remoteId, framesEncoded</li> | ||
| <li>RTCRemoteOutboundRTPStreamStats, with all required attributes from | ||
| its inherited dictionaries, and also attributes localId, remoteTimestamp | ||
| </li> |
There was a problem hiding this comment.
Below this point: trackIdentifier, remoteSource, ended has moved from RTCMediaStreamTrackStats to RTCMediaHandlerStats. I think we should add "kind" as mandatory to RTCMediaHandlerStats.
frameWidth, frameHeight, framesPerSecond has moved to RTCVideoHandlerStats.
framesSent, has moved to RTCVideoSenderStats.
framesReceiverd, framesDecoded, framesDropped has moved to RTCVideoReceiverStats.
framesCorrupted seems to have disappeared - was it ever defined?
audioLevel has moved to RTCAudioHandlerStats.
RTCIceCaindidatePairStats.priority has been removed from RTCIceCandidatePairStats due to problems representing 64 significant bits in the 53 effective bits of "long long".
I think that's all.
Fix for Issue #833 Related WebRTC 1.-0 PR: w3c/webrtc-pc#1803
|
@alvestrand Better now? |
Rebase of #1782
Fix for Issue #1771
Preview | Diff