Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit sendEncodings to video. #1814

Closed
wants to merge 1 commit into from
Closed

Conversation

jan-ivar
Copy link
Member

@jan-ivar jan-ivar commented Mar 22, 2018

Potential fix for #1813.


Preview | Diff

@@ -5159,7 +5159,7 @@ <h2>Methods</h2>
non-null value, as defined in <span data-jsep=
"processing-a-local-desc processing-a-remote-desc">[[!JSEP]]</span>.</p>
<p>The <code>sendEncodings</code> argument can be used to
specify the number of offered simulcast encodings, and
specify the number of offered simulcast encodings for video, and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So outside of WebRTC, we o simulcast for audio too. Why would be limit it to video ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fluffy Because of costs of implementing, testing and supporting any feature? Not to mention that features without strong use-cases driving them tend to end up broken anyway. I think the question must be flipped around: Why wouldn't simulcast be limited to video?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with it being optional for browser to implement, but I don't think it should be forbidden. Many people in Africa are working across satellite links and they often can't use anything except very low bit rate audio while people on the thick pipes want high bandwidth. If you want to do this in a way where the media is encrypted, some clients need to send a high and low bandwidth version of the audio. Then the cloud can forward the appropriate bandwidth one to people that are listening.

@fluffy
Copy link
Contributor

fluffy commented Mar 22, 2018 via email

@jan-ivar
Copy link
Member Author

I was asked by @aboba to put up this PR. I also solicited opinions internally at Mozilla and the opinion was simulcast for audio made no sense. We should probably move discussion to #1813.

@jan-ivar
Copy link
Member Author

jan-ivar commented Apr 5, 2018

I'm closing PR until discussion concludes in #1813.

@jan-ivar jan-ivar closed this Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants