Removing references to OAUTH-POP-KEY-DISTRIBUTION. #1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes w3c#1642. RFC7635 does not actually require the OAuth Client (the web application, in WebRTC context) to use OAUTH-POP-KEY-DISTRIBUTION; this is just the example provided in Appendix B. So this PR removes all references to it, saying "how the application gets the kid/accessToken/macKey is unspecified, Appendix B provides one example mechanism." Also doing some unrelated shuffling around of paragraphs to make things more readable. For example, moving terminology to the Terminology section, and introducing the concepts of macKey/accessToken/kid before we talk about refreshing them.
taylor-b
force-pushed
the
issue_1642_oauth
branch
from
bc05084
to
cb33509
Compare
|
@misi, does this look good? |
misi
reviewed
Apr 22, 2018
webrtc.html
Outdated
| <p>For OAuth Authentication, the <a>ICE Agent</a> requires three | ||
| pieces of credential information. The credential is composed of | ||
| a <code>kid</code>, which the <a>RTCIceServer</a> | ||
| <code>username</code> member is used for, and | ||
| <code>macKey</code> and <code> accessToken</code>, which are | ||
| placed in the <a>RTCOAuthCredential</a> dictionary. All of this | ||
| information can be extracted from the OAuth response parameters, | ||
| which are received from the <dfn>Authorization Server</dfn>. The | ||
| which are received from the <a>Authorization Server</a>. The | ||
| relevant OAuth response parameters are the "kid", the "key", and |
There was a problem hiding this comment.
These names ("kid","key","access_token") of the OAuth response parameters are from POP key distribution draft, and may we should also remove to refer to them. According the actual changes we should rather state only that
OAuth Client provide all necessary information (the kid, macKey, and accessToken) that are required by the ICE Agent for the Authentication.
There was a problem hiding this comment.
Good catch; removed everything in this paragraph from "All of this information..." onward. I think the "note" section below should clarify things sufficiently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1642.
RFC7635 does not actually require the OAuth Client (the web application,
in WebRTC context) to use OAUTH-POP-KEY-DISTRIBUTION; this is just the
example provided in Appendix B. So this PR removes all normative
references to it, saying "how the application gets the kid/accessToken/macKey
is outside the scope of this spec; Appendix B provides one example mechanism."
Also doing some unrelated shuffling around of paragraphs to make things
more readable. For example, moving terminology to the Terminology
section, and introducing the concepts of macKey/accessToken/kid before
we talk about refreshing them.
Preview | Diff