Update a receiver's set of remote streams when "a=msid" lines change. #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes w3c#1609. This PR updates the `[[AssociatedRemoteMediaStreams]]` slot in every `setRemoteDescription` call, even if the direction isn't changing, and also adds: - A `getStreams()` method to `RTCRtpReceiver`, just returning the value of the internal slot. - A `streamsupdated` event, to tell when the set of stremas changes. Fired at the end of `setRemoteDescription` like everything else.
|
There's new API in here, so we need list discussion, and perhaps a new VI topic. |
|
We might fire the track event again, rather than adding a setstreams event. (Jan-Ivar's comment). |
|
Discussed this with editors today, and we favor firing the |
Closed
|
Closing this in favor of #1947. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1609.
This PR updates the
[[AssociatedRemoteMediaStreams]]slot in everysetRemoteDescriptioncall, even if the direction isn't changing, andalso adds:
getStreams()method toRTCRtpReceiver, just returning the valueof the internal slot.
streamsupdatedevent, to tell when the set of streams changes.Fired at the end of
setRemoteDescriptionlike everything else.