RTCSctpTransportState cleanup #1928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvestrand
approved these changes
Jul 11, 2018
webrtc.html
Outdated
| (such as by closing the peer connection or applying a | ||
| remote description that rejects data or changes the | ||
| SCTP port) or via receipt of a SHUTDOWN or ABORT chunk.</p> | ||
| SCTP port) or when a SHUTDOWN or ABORT chunk is received, |
There was a problem hiding this comment.
Grammatically, this last piece doesn't make sense any more. If you replace "or" with "." (turning "when a SHUTDOWN" into a new sentence), it makes sense; would perhaps make more sense to move the "when a SHUTDOWN" part into text about the overall operation of an SCTP association (if one exists).
|
This looks good to me (thanks for taking some weight off my shoulders). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issues #1633 and #1874
Preview | Diff