Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding canTrickleIceCandidates #20

Merged
merged 2 commits into from
Dec 11, 2014
Merged

Adding canTrickleIceCandidates #20

merged 2 commits into from
Dec 11, 2014

Conversation

martinthomson
Copy link
Member

As discussed in TPAC '14

@juberti
Copy link
Contributor

juberti commented Oct 31, 2014

See comment in JSEP pull, should this be .canTrickleIceCandidates to better match addIceCandidate() and onicecandidate

@martinthomson
Copy link
Member Author

You just want to punish me for doing the work. I'll fix it up eventually.

@juberti
Copy link
Contributor

juberti commented Nov 1, 2014

not sure I would call adding 10 more characters on line 1245 a punishment, but if you want to two-step it, sure.

@martinthomson
Copy link
Member Author

Attribute it to snark. I've a large enough pile of edits to do. This will hardly make a dent.

@martinthomson martinthomson changed the title Adding canTrickleIce Adding canTrickleIceCandidates Nov 4, 2014
@ibc
Copy link

ibc commented Nov 4, 2014

I don't understand. This attribute canTrickleIceCandidates seems to tell the application how to signal the media description stuff (this is, whether the application can signal trickle ICE candidates or just the whole SDP containing all the definitive candidates).

Isn't the application supposed to decide how to signal everything?

@juberti
Copy link
Contributor

juberti commented Nov 5, 2014

LGTM
This lets the app know if it is talking to an endpoint that supports trickle or not. Otherwise, it needs to inspect SDP, or communicate this out of band.

@fluffy
Copy link
Contributor

fluffy commented Nov 5, 2014

LGTM

1 similar comment
@stefhak
Copy link
Contributor

stefhak commented Nov 6, 2014

LGTM

@fluffy
Copy link
Contributor

fluffy commented Dec 4, 2014

Still LGTM

@stefhak
Copy link
Contributor

stefhak commented Dec 5, 2014

Any Editor willing to merge?

fluffy added a commit that referenced this pull request Dec 11, 2014
@fluffy
Merge pull request #20 from martinthomson/cantrickle
26dbb0e 
Adding canTrickleIceCandidates
@fluffy fluffy merged commit 26dbb0e into w3c:master Dec 11, 2014
@dontcallmedom dontcallmedom mentioned this pull request Dec 15, 2014
Closed
dontcallmedom pushed a commit that referenced this pull request Aug 26, 2016
@astorije
Fix #20: Remove the broken placeholder image and center blocks
60baa79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@martinthomson @juberti @ibc @fluffy @stefhak