Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "bufferedamountlow" event. #233

Merged
merged 4 commits into from
Jun 4, 2015
Merged

Add a "bufferedamountlow" event. #233

merged 4 commits into from
Jun 4, 2015

Conversation

bemasc
Copy link
Contributor

@bemasc bemasc commented May 28, 2015

Fixes #232

The <code><a href=
"#dom-datachannel-lowbufferlimit">lowBufferLimit</a></code>
defaults to zero, but the application may change its value at any
time.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that you want to say that this value starts at zero rather than defaults.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I've improved the wording here.

@bemasc
Copy link
Contributor Author

bemasc commented May 28, 2015

I didn't add an onbufferlow because I think onwhatever is rightly deprecated (and there's no compatibility concern for new events), but if you want to keep parallelism I'm happy to add it.

OK, I've changed the names to bufferedAmountLowThreshold and bufferedamountlow.

@jan-ivar
Copy link
Member

@bemasc - Do you have a link about onwhatever being deprecated?

@bemasc
Copy link
Contributor Author

bemasc commented May 28, 2015

Mozilla says "If you're working with a modern browser, use addEventListener() instead."

onwhatever has been removed entirely from the DOM Level 2 Events and is never mentioned in the living standard. Admittedly, I haven't found any explicit guidance on whether to include it for new events or not.

@jan-ivar
Copy link
Member

Thanks for the link. PeerConnection has onxxx for all its events I think, and AFAIK they were all added after this advice.

Also improve phrasing.
@bemasc
Copy link
Contributor Author

bemasc commented May 29, 2015

OK, I've added onbufferedamountlow.

@bemasc bemasc changed the title Add a "bufferlow" event. Add a "bufferedamountlow" event. Jun 1, 2015
alvestrand added a commit that referenced this pull request Jun 4, 2015
Add a "bufferedamountlow" event.
@alvestrand alvestrand merged commit 837ca6a into w3c:master Jun 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to limit bufferedAmount without polling
5 participants