Remove voiceActivityFlag from RTCOfferAnswerOptions #2352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henbos
commented
Nov 7, 2019
| >dictionary RTCOfferAnswerOptions { | ||
| boolean voiceActivityDetection = true; | ||
| };</pre> | ||
| >dictionary RTCOfferAnswerOptions {};</pre> |
There was a problem hiding this comment.
Note: After this PR there is a single reference to voiceActivityDetection that still remains: The one inside of "dtx" attribute definition which is removed in #2351. Not touching it here avoids a merge conflict. But if that PR does not land this PR need to be updated to remove that reference.
aboba
approved these changes
Nov 7, 2019
jan-ivar
approved these changes
Nov 7, 2019
sideshowbarker
added a commit
to w3c/browser-compat-data
that referenced
this pull request
Jan 25, 2020
w3c/webrtc-pc#2352 removed the voiceActivityDetection member from the RTCRtcpMuxPolicy interface. w3c/webrtc-pc@467fa36 So, this change marks voiceActivityDetection as deprecated and non-standard-track.
sideshowbarker
added a commit
to w3c/browser-compat-data
that referenced
this pull request
Jan 25, 2020
w3c/webrtc-pc#2352 removed the voiceActivityDetection member from the RTCOfferAnswerOptions interface. w3c/webrtc-pc@467fa36 So, this change marks voiceActivityDetection as deprecated and non-standard-track.
queengooborg
pushed a commit
to mdn/browser-compat-data
that referenced
this pull request
Jan 26, 2020
w3c/webrtc-pc#2352 removed the voiceActivityDetection member from the RTCOfferAnswerOptions interface. w3c/webrtc-pc@467fa36 So, this change marks voiceActivityDetection as deprecated and non-standard-track.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2349
Preview | Diff