Note that getSynchronizationSources works without sinks #2385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henbos
commented
Nov 28, 2019
henbos
added
Needs Test
Arctunix
reviewed
Nov 28, 2019
webrtc.html
Outdated
| @@ -7197,6 +7197,10 @@ <h2>Methods</h2> | |||
| in order of ascending RTP timestamps. The user agent MUST keep information | |||
| from RTP packets delivered to the <code><a>RTCRtpReceiver</a></code>'s | |||
| <code><a>MediaStreamTrack</a></code> in the previous 10 seconds.</p> | |||
| <div class="note">Even if the <a>MediaStreamTrack</a> is not attached to | |||
| any sink for playout, <code>getSynchronizationSources</code> and | |||
| <code>getContributingSources</code> returns up-to-date information; sinks | |||
There was a problem hiding this comment.
Would it make sense to change "returns" to "MUST return"?
There was a problem hiding this comment.
This is a note, I think we're covered by the previous "MUST" above that this note is referring to :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2240
Preview | Diff