Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race in perfect negotiation example. #2406

Merged
merged 1 commit into from Dec 12, 2019
Merged

Fix race in perfect negotiation example. #2406

merged 1 commit into from Dec 12, 2019

Conversation

jan-ivar
Copy link
Member

@jan-ivar jan-ivar commented Dec 11, 2019 •
edited by pr-preview bot

The other half of the fix for #2404.

Preview | Diff

@jan-ivar jan-ivar self-assigned this Dec 11, 2019
henbos
henbos approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@henbos henbos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense too, but this is the kind of thing I would like to see a lot of tests for, since it's so timing-sensitive.

@henbos henbos added the Needs Test Needs a WPT test label Dec 12, 2019
@henbos henbos merged commit 7d833a1 into w3c:master Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henbos henbos henbos approved these changes

@alvestrand alvestrand Awaiting requested review from alvestrand

@aboba aboba Awaiting requested review from aboba

Assignees

@jan-ivar jan-ivar

Labels
Editorial Needs Test Needs a WPT test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jan-ivar @henbos