Test coverage Section 5.4.1 (Simulcast) #2525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial fix for Issue #2470
alvestrand
reviewed
May 7, 2020
| @@ -7703,11 +7703,11 @@ <h3>Simulcast functionality</h3> | |||
| permit all simulcast streams to be sent in an usable form, | |||
| the user agent is expected to stop sending some of the simulcast streams. | |||
| </p> | |||
| <p data-tests="">As defined in <span data-jsep="simulcast">[[!JSEP]]</span>, an offer from a user-agent | |||
| <p data-tests="basic.https.html">As defined in <span data-jsep="simulcast">[[!JSEP]]</span>, an offer from a user-agent | |||
henbos
reviewed
May 7, 2020
| @@ -7670,29 +7670,29 @@ <h2>Methods</h2> | |||
| </div> | |||
| <section> | |||
| <h3>Simulcast functionality</h3> | |||
| <p>Simulcast functionality is provided via the {{RTCPeerConnection/addTransceiver}} method of the | |||
| <p data-test="basic.https.html">Simulcast functionality is provided via the {{RTCPeerConnection/addTransceiver}} method of the | |||
alvestrand
reviewed
May 7, 2020
| will only contain a "send" description and no "recv" description on the | ||
| <code class=sdp>a=simulcast</code> line. Alternatives and restrictions (described | ||
| in [[MMUSIC-SIMULCAST]]) are not supported.</p> | ||
| <p>This specification does not define how to configure reception of multiple | ||
| <p class="test-needed">This specification does not define how to configure reception of multiple |
There was a problem hiding this comment.
test-needed -> needs-test
henbos
reviewed
May 7, 2020
| will only contain a "send" description and no "recv" description on the | ||
| <code class=sdp>a=simulcast</code> line. Alternatives and restrictions (described | ||
| in [[MMUSIC-SIMULCAST]]) are not supported.</p> | ||
| <p>This specification does not define how to configure reception of multiple | ||
| <p class="test-needed">This specification does not define how to configure reception of multiple |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for Issue #2470
Preview | Diff