-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disambiguate all uses of RTCSessionDescription. #2614
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good directionally, but with some changes needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some comments but happy with "editors can integrate"
The chairs/etc will have to decide what to do with editorial issues this point in time. |
@dontcallmedom Should we merge these editorial PRs to get them in, or hold off? |
We thought it looked good but the concern came up of "what if we accidentally introduce a bug before the cut" so we need some stance on what to do with minor editorial changes this late in the process |
from a process perspective merging them in is OK; but the concerns about introducing late bugs in what looks editorial is also reasonable. My guess is that if enough eyeballs have taken a hard look at the PR, then merging should be OK. |
Thanks @dontcallmedom and @henbos. I've looked over the PR again and I found no mistakes.
I think this is an improvement., so I'd like to get this in before the Dec 15th deadline. @alvestrand and @aboba can I get an |
Actually, it's not vague because an |
I am happy with editors can integrate but I have already approved it. So can @alvestrand or @aboba give their thumbs up or down? |
Thanks @alvestrand I take that as a sign to go ahead. |
Fixes #1477.
Preview | Diff