simulcast example: remove signalling offer handling #2636
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which does not apply to this example
|
dontcallmedom marked as non substantive for IPR from ash-nazg. |
jan-ivar
requested changes
Apr 1, 2021
Comment on lines
-16281
to
-16285
| // if we got an offer, we need to reply with an answer | ||
| if (description.type == 'offer') { | ||
| await pc.setLocalDescription(); | ||
| signaling.send({description: pc.localDescription}); | ||
| } |
There was a problem hiding this comment.
The conferencing server may send an offer to receive simulcast. So applications may need to handle this.
Also, to handle renegotiation for stuff I don't think we should customize the negotiation handling code.
I vote against merging this.
There was a problem hiding this comment.
We could add something to the comment:
// if we got an offer, we need to reply with an answer. This might
// happen e.g. if a server later wants to send media back to the client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which does not apply to this example
Preview | Diff