Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IDL indenting #2683

Merged
merged 2 commits into from Oct 21, 2021
Merged

Fix IDL indenting #2683

merged 2 commits into from Oct 21, 2021

Conversation

dontcallmedom
Copy link
Member

@dontcallmedom dontcallmedom commented Oct 15, 2021

problem caused by overeager tidy in d3f0012
close #2682


Preview | Diff

problem caused by overeager tidy in d3f0012
close #2682
@fippo
Copy link
Contributor

fippo commented Oct 15, 2021

i'll call you Sísyphos instead <3

@marcoscaceres
Copy link
Member

This is still kinda ugly... why not do just do?:

<pre class="WebIDL">
   interface Foo {
     // other stuff 
   };
</pre> 

Tidy shouldn't touch those and there is no other technical reason not to do them all like the above, AFAIK?

@marcoscaceres
Copy link
Member

Screen Shot 2021-10-21 at 11 45 24 am

Renders as:

Screen Shot 2021-10-21 at 11 45 58 am

Which is what we want...

webrtc.html Outdated Show resolved Hide resolved
webrtc.html Outdated Show resolved Hide resolved
webrtc.html Outdated Show resolved Hide resolved
Co-authored-by: Marcos Cáceres <marcos@marcosc.com>
@alvestrand alvestrand merged commit 8907be1 into main Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

some webidl things are indented wrongly
4 participants