Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError on duplicate rids #2775

Merged
merged 3 commits into from
Oct 13, 2022
Merged

TypeError on duplicate rids #2775

merged 3 commits into from
Oct 13, 2022

Conversation

jan-ivar
Copy link
Member

@jan-ivar jan-ivar commented Sep 26, 2022 •
edited by pr-preview bot
Loading

Fixes #2733.

Preview | Diff

@jan-ivar jan-ivar self-assigned this Sep 26, 2022
dontcallmedom
dontcallmedom reviewed Sep 27, 2022
View reviewed changes
webrtc.html Show resolved Hide resolved
webrtc.html Show resolved Hide resolved
@jan-ivar jan-ivar mentioned this pull request Sep 29, 2022
Merged
@dontcallmedom dontcallmedom added the Simulcast Issue relating to Simulcast label Oct 12, 2022
@jan-ivar jan-ivar merged commit aac8167 into w3c:main Oct 13, 2022
@jan-ivar jan-ivar deleted the uniquerids branch October 13, 2022 20:54
@dontcallmedom dontcallmedom mentioned this pull request Nov 15, 2023
Merged
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dontcallmedom dontcallmedom dontcallmedom left review comments

@youennf youennf youennf approved these changes

@alvestrand alvestrand Awaiting requested review from alvestrand

@aboba aboba Awaiting requested review from aboba

Assignees

@jan-ivar jan-ivar

Labels
Editors can integrate Simulcast Issue relating to Simulcast
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

addTransceiver does not check for uniqueness of rid
4 participants
@jan-ivar @dontcallmedom @youennf @alvestrand