New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow encoder resolution alignment in scaleResolutionDownBy. #2808

Merged

jan-ivar merged 11 commits into w3c:main from jan-ivar:downscalehw

Jan 5, 2023

Member

jan-ivar commented Dec 14, 2022 •

edited by pr-preview bot

Loading

Fixes #2802.


          Allow encoder resolution alignment in scaleResolutionDownBy.

61123ca

jan-ivar requested review from Orphis, alvestrand, aboba and youennf

December 14, 2022 00:00

jan-ivar self-assigned this

jan-ivar added 2 commits

December 16, 2022 14:23


          Downscale instead of upscale for alignment.

356cc3b


          fix typo in last commit

2b205f6

jan-ivar commented

View reviewed changes

webrtc.html Outdated Show resolved Hide resolved

jan-ivar added 3 commits

December 16, 2022 15:09


          Limit floor() sentence to scaleResolutionDownBy

17eaa55


          clarify integer part means scaled width and height

5e0f5a1


          s/send/transmit/ for consistency + wordwrap

76d0304

jan-ivar commented

View reviewed changes

webrtc.html Outdated Show resolved Hide resolved

jan-ivar and others added 2 commits

December 16, 2022 15:22


          s/restrictions/limitations/ of the encoder

e8b47e1


          Rephrase to clarify rescaling requirement is over time.

b0d8cd6

jan-ivar commented

View reviewed changes

webrtc.html Outdated Show resolved Hide resolved


          Rephrase to clarify rescaling requirement applies over time.

794b74e

Pehrsons reviewed

View reviewed changes

webrtc.html Outdated Show resolved Hide resolved

Pehrsons reviewed

View reviewed changes

webrtc.html Outdated Show resolved Hide resolved

jan-ivar added 2 commits

January 4, 2023 19:00


          merge wordwrap change

d2ebd5f


          Move some prose and rephrase + clamp srdb to > encoder minimum

f68fce2

Member Author

jan-ivar commented Jan 5, 2023

I find looking at the preview helpful here as there are multiple separate paragraphs meant to be read in sequence.

jan-ivar merged commit cd197d8 into w3c:main

jan-ivar deleted the downscalehw branch

January 5, 2023 15:12

dontcallmedom mentioned this pull request

Document test updates associated with amendments #2910

Merged

23 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment