Name and export the RTCIceTransport state update algo #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: w3c#2904. The RTCIceTransport algorithm for a change of the selected candidate pair or RTCIceTransportState is referenced in webrtc-extensions currently without a proper link because it is not exported from webrtc-pc. So name and export the algorithm.
|
Re. the failing check, I believe this change qualifies as Editorial rather than an amendment. |
jan-ivar
reviewed
Nov 9, 2023
webrtc.html
Outdated
Comment on lines
12163
to
12164
| changing. The <dfn class="export" data-lt="change of selected candidate pair or state">change of the selected pair and | ||
| {{RTCIceTransportState}}</dfn> are related |
There was a problem hiding this comment.
I think this needs to go in the paragraph below where the algorithm is invoked. E.g.
When the [= ICE Agent =] indicates that an {{RTCIceTransport}} has
changed either the selected candidate pair, the
{{RTCIceTransportState}} or both, the user agent MUST queue a task
that runs these [steps to change pair and state] algorithm:
jan-ivar
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2904.
The RTCIceTransport algorithm for a change of the selected candidate pair or RTCIceTransportState is referenced in webrtc-extensions currently without a proper link because it is not exported from webrtc-pc. So name and export the algorithm.
Preview | Diff