Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove setCodecPreferences note already covered by JSEP #2941

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

fippo
Copy link
Contributor

@fippo fippo commented Feb 20, 2024

fixes #2933

I'd classify this as editorial


Preview | Diff

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Feb 21, 2024
asserting what was said in the note that was
removed as redundant with JSEP:
  w3c/webrtc-pc#2941

BUG=None

Change-Id: I6ed59532788ef7bd2a3e3a9ae17c40076b39f747
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Feb 21, 2024
asserting what was said in the note that was
removed as redundant with JSEP:
  w3c/webrtc-pc#2941

BUG=None

Change-Id: I6ed59532788ef7bd2a3e3a9ae17c40076b39f747
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310061
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Florent Castelli <orphis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1263260}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Feb 21, 2024
asserting what was said in the note that was
removed as redundant with JSEP:
  w3c/webrtc-pc#2941

BUG=None

Change-Id: I6ed59532788ef7bd2a3e3a9ae17c40076b39f747
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310061
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Florent Castelli <orphis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1263260}
@alvestrand alvestrand merged commit 3d6e620 into w3c:main Feb 22, 2024
3 of 4 checks passed
@fippo fippo deleted the dont-overspecify branch February 22, 2024 15:38
marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this pull request Feb 23, 2024
asserting what was said in the note that was
removed as redundant with JSEP:
  w3c/webrtc-pc#2941

BUG=None

Change-Id: I6ed59532788ef7bd2a3e3a9ae17c40076b39f747
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310061
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Florent Castelli <orphis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1263260}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Feb 28, 2024
…e, a=testonly

Automatic update from web-platform-tests
webrtc wpt: add test for removed sCP note

asserting what was said in the note that was
removed as redundant with JSEP:
  w3c/webrtc-pc#2941

BUG=None

Change-Id: I6ed59532788ef7bd2a3e3a9ae17c40076b39f747
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310061
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Florent Castelli <orphis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1263260}

--

wpt-commits: 89d651c02dd9c3a01cd6e05e011d1c362f2122c1
wpt-pr: 44698
ErichDonGubler pushed a commit to ErichDonGubler/firefox that referenced this pull request Feb 28, 2024
…e, a=testonly

Automatic update from web-platform-tests
webrtc wpt: add test for removed sCP note

asserting what was said in the note that was
removed as redundant with JSEP:
  w3c/webrtc-pc#2941

BUG=None

Change-Id: I6ed59532788ef7bd2a3e3a9ae17c40076b39f747
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310061
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Florent Castelli <orphis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1263260}

--

wpt-commits: 89d651c02dd9c3a01cd6e05e011d1c362f2122c1
wpt-pr: 44698
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Existing setCodecPreferences NOTE is wrong and should be deleted
2 participants