-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify description.toJSON() returns RTCSessionDescriptionInit #2968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng state, and ice connection state, and fix ongatheringstatechange to use the right one.
since it is typically paired with the MTI totalRoundTripTime https://www.w3.org/TR/webrtc-stats/#dom-rtcicecandidatepairstats-totalroundtriptime to calculate the average RTT and totalRoundTripTime is meaningless without it.
Annotate amendment boxes
Add internal slots for signaling state, connection state, ice gatheri…
Those two objects are closely related and the parameters type should reuse the capability definition to prevent them from diverging. It would also allow using an RTCRtpCodecParameters instance with the upcoming encoder codec selection API.
Create RTCRtpCodec dictionary and reuse in RTCRtpCodecParameters and RTCRtpCodecCapability definitions
Fix scaleResolutionDownBy explanatory prose to match normative algorithm
Make RTCRtpHeaderExtensionCapability.uri required
Mark PreferredCodec internal slot as exported
Fix bugs in amendments
Make RTCIceCandidatePair members required
Queue two tasks upon finishing ICE gathering, and fire gatheringstatechange & icegatheringstatechange in same task
Fix amendments
Integrate jitterBufferTarget as candidate addition
Export RTCRtpReceiver.ReceiveCodec
Rename to "codec dictionary match" algorithm and remove index consistency claim
Have setCodecPreferences take sequence<RTCRtpCodec>
Update to ReSpec version 35.0.0
Avoid setCodecPreferences confusion over which duplicates are removed
Replace references to RFC8829 with RFC9429
Whoops, wrong push. Please ignore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For clarity (we do this with RTCIceCandidate already).
💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on May 2, 2024, 5:10 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 [Related URL]([object Object])
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.