Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify description.toJSON() returns RTCSessionDescriptionInit #2968

Closed
wants to merge 2,308 commits into from

Conversation

jan-ivar
Copy link
Member

@jan-ivar jan-ivar commented May 2, 2024

For clarity (we do this with RTCIceCandidate already).


💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on May 2, 2024, 5:10 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.

🔗 [Related URL]([object Object])


😭  Sorry, there was an error generating the HTML. Please report this issue!
Specification: http://localhost:8082/uploads/QhHEKQ/webrtc.html?isPreview=true%3FisPreview%3Dtrue&publishDate=2024-05-02
ReSpec version: 12.2.2
File a bug: https://github.com/w3c/respec/
Error: TypeError: exportDocument is not a function
    at evaluateHTML (evaluate at generateHTML (file:///u/spec-generator/node_modules/respec/tools/respecDocWriter.js:229:23), <anonymous>:20:11)
    at #evaluate (file:///u/spec-generator/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/ExecutionContext.js:219:19)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async ExecutionContext.evaluate (file:///u/spec-generator/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/ExecutionContext.js:114:16)
    at async IsolatedWorld.evaluate (file:///u/spec-generator/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/IsolatedWorld.js:121:16)
    at async CdpFrame.evaluate (file:///u/spec-generator/node_modules/puppeteer-core/lib/esm/puppeteer/api/Frame.js:350:20)
    at async CdpPage.evaluate (file:///u/spec-generator/node_modules/puppeteer-core/lib/esm/puppeteer/api/Page.js:814:20)
    at async generateHTML (file:///u/spec-generator/node_modules/respec/tools/respecDocWriter.js:229:12)
    at async toHTML (file:///u/spec-generator/node_modules/respec/tools/respecDocWriter.js:100:18)
    at async Object.generate [as respec] (file:///u/spec-generator/generators/respec.js:15:44)

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

jan-ivar and others added 30 commits March 6, 2023 16:20
…ng state, and ice connection state, and fix ongatheringstatechange to use the right one.
since it is typically paired with the MTI totalRoundTripTime
  https://www.w3.org/TR/webrtc-stats/#dom-rtcicecandidatepairstats-totalroundtriptime
to calculate the average RTT and totalRoundTripTime is meaningless
without it.
Add internal slots for signaling state, connection state, ice gatheri…
Those two objects are closely related and the parameters type should
reuse the capability definition to prevent them from diverging.
It would also allow using an RTCRtpCodecParameters instance with the
upcoming encoder codec selection API.
Create RTCRtpCodec dictionary and reuse in RTCRtpCodecParameters and RTCRtpCodecCapability definitions
Fix scaleResolutionDownBy explanatory prose to match normative algorithm
Make RTCRtpHeaderExtensionCapability.uri required
Mark PreferredCodec internal slot as exported
aboba and others added 26 commits March 28, 2024 08:27
Make RTCIceCandidatePair members required
Queue two tasks upon finishing ICE gathering, and fire gatheringstatechange & icegatheringstatechange in same task
Integrate jitterBufferTarget as candidate addition
Export RTCRtpReceiver.ReceiveCodec
Rename to "codec dictionary match" algorithm and remove index consistency claim
Have setCodecPreferences take sequence<RTCRtpCodec>
Update to ReSpec version 35.0.0
Avoid setCodecPreferences confusion over which duplicates are removed
Replace references to RFC8829 with RFC9429
@jan-ivar jan-ivar self-assigned this May 2, 2024
@jan-ivar
Copy link
Member Author

jan-ivar commented May 2, 2024

Whoops, wrong push. Please ignore

@jan-ivar jan-ivar closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet