Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add languages on how to choose IP addresses. #444

Closed
wants to merge 4 commits into from

Conversation

guoweis-work
Copy link

No description provided.

@@ -7698,7 +7698,9 @@ <h3 id="sec.identity-verify-assertion">Verifying Identity Assertions</h3>
session.</p>

<p>Revealing IP addresses can leak location and means of
connection; this can be sensitive.</p>
connection; this can be sensitive but necessary for establishing peer to
peer connections. The choice of which addresses to expose is controlled by
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to change "which addresses to expose" into "which addresses to expose and when to expose them"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would "is determined by" be more accurate than "is controlled by"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL.

Thanks,
Guowei

On Mon, Dec 28, 2015 at 3:21 PM, Peter Thatcher notifications@github.com
wrote:

In webrtc.html
#444 (comment):

@@ -7698,7 +7698,9 @@

Verifying Identity Assertions


session.

 <p>Revealing IP addresses can leak location and means of
  • connection; this can be sensitive.

  • connection; this can be sensitive but necessary for establishing peer to
  • peer connections. The choice of which addresses to expose is controlled by

Would "is determined by" be more accurate than "is controlled by"?


Reply to this email directly or view it on GitHub
https://github.com/w3c/webrtc-pc/pull/444/files#r48512623.

@alvestrand
Copy link
Contributor

Thanks - this is also covered in #439 - @dontcallmedom and @guoweis - please make sure language is compatible;M it would be nice to merge this only once.

@guoweis-work
Copy link
Author

I see that dontcallmedom's write up has covered what I intended to say. I
can close #444 as a dup.

Thanks,
Guowei

On Tue, Jan 5, 2016 at 11:05 AM, Harald Alvestrand <notifications@github.com

wrote:

Thanks - this is also covered in #439
#439 - @dontcallmedom
https://github.com/dontcallmedom and @guoweis
https://github.com/guoweis - please make sure language is compatible;M
it would be nice to merge this only once.


Reply to this email directly or view it on GitHub
#444 (comment).

@guoweis-work
Copy link
Author

This is a dup with #439

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants