Use enum for voiceActivityDetection #467
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
part of #375, based on @martinthomson's [suggestion](#375 (comment))
|
As we go through the consequences of eliminating true defaults, it gets uglier. Comments wanted. |
|
If vad is a feature that should be default on because that's what would benefit most people, would it be so bad to have an option called 'disableVoiceActivityDetection'? |
|
I rather like @adam-be 's suggestion. |
|
I don't like negative-valued options - "disableVoiceActivityDetection: false" is a double negative. |
| <dd>Request voice activity detection to be enabled</dd> | ||
|
|
||
| <dt>disabled</dt> | ||
| <dd>Request voice activity detection to be disabled</dd> |
There was a problem hiding this comment.
Should we have periods at the end of the sentences?
There was a problem hiding this comment.
Otherwise, I'm fine with this.
|
Closed based on list call-for-consensus results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #375, based on @martinthomson's suggestion