Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add activateReceiver method to RTCRtpTransceiver #505

Merged
merged 1 commit into from
Feb 25, 2016

Conversation

aboba
Copy link
Contributor

@aboba aboba commented Feb 16, 2016

Add activateReceiver method to the RTCRtpTransceiver

Related to Issue #473

@aboba aboba changed the title Add getParameters() method to RTCRtpReceiver Add activateReceiver method to RTCRtpTransceiver Feb 16, 2016
@aboba
Copy link
Contributor Author

aboba commented Feb 17, 2016

@pthatcherg Can you review?


<p>If the receiver is not already active and the PeerConnection is in the stable state,
this will set the <code>negotiationneeded</code> flag.
</dd>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping we would need only one "set horrible" (activateSender()) and not two (activateReceiver()).

Does this accomplish anything other than a way to tell the sending side "please stop sending me this track" without rejecting the whole m-line?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we need it, this PR looks good.

@aboba
Copy link
Contributor Author

aboba commented Feb 17, 2016

Implementing various "hold" scenarios appears to require both "set horrible" methods.

For example, if addTransceiver(init) is called with init.send=true and init.receive=false (e.g. sendonly), activateReceiver() can be used to go from sendonly to sendrecv, taking the remote peer off hold (after another O/A exchange).

See the "hold" example, in http://tools.ietf.org/html/rfc4317 Section 3.1.

alvestrand added a commit that referenced this pull request Feb 25, 2016
Add activateReceiver method to RTCRtpTransceiver
@alvestrand alvestrand merged commit 276da51 into master Feb 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants