Use 'create an RTCRtpSender/Receiver/Transceiver' definitions (from #702) in addTransceiver() #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-be
force-pushed
the
fix-add-transceiver
branch
from
beab0f5
to
50eec67
Compare
adam-be
force-pushed
the
fix-add-transceiver
branch
from
50eec67
to
913ea0d
Compare
|
This one should be easier to review now when #702 is merged and not included in the aggregated diff of this PR. |
| <p>RID values passed into <code>init.sendEncodings</code> must be | ||
| composed only of case-sensitive alphanumeric characters (a-z, | ||
| A-Z, 0-9) up to a maximum of 16 characters.</p> | ||
| <p>When this method is invoked, the User Agent must run the |
|
Thanks for the review @dontcallmedom. I'll merge this when the bots turn green, but please file issues on the unclarities you found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this PR is based on #702