Improve error handling for IdP proxy interactions #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <code>RTCPeerConnection</code> and generates an identity assertion | ||
| asynchronously.</p> | ||
| <p>If the user has been authenticated by the IdP, and the IdP is | ||
| willing to generate an identity assertion, the IdP resolves the |
There was a problem hiding this comment.
This part is a bit confusing. First it says IdP proxy ... generates an identity assertion and then if ... the IdP is willing to generate an identity assertion. It looks like the IdP proxy has already generated that one.
There was a problem hiding this comment.
Do you think that I should say "attempts to generate an identity assertion"?
|
As far as I can judge, this PR looks good (two minor comments above). |
|
Thanks for the update @martinthomson. To me (admitting I'm an IdP novice) this looks ready to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #562.