Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaceTrack with the previous one as ended #758

Merged
merged 3 commits into from
Aug 25, 2016
Merged

Conversation

aboba
Copy link
Contributor

@aboba aboba commented Aug 23, 2016

Fix for Issue #732

@@ -2892,10 +2892,6 @@
connection will be marked as needing negotiation. Examples of such
operations include adding or stopping a track, or adding the first data
channel.</p>
<p>Internal changes within the implementation can also result in the
connection being marked as needing negotiation. For example, if a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest only removing the part after the dot (For example).

Leave some text
@adam-be
Copy link
Member

adam-be commented Aug 25, 2016

Do we need to add text that says that an RTCRtpSender sees a track as muted if it ends?

Add mute explanation
@alvestrand alvestrand merged commit 909056f into master Aug 25, 2016
aboba added a commit to w3c/ortc that referenced this pull request Sep 9, 2016
Fix for Issue: #589
Related to WebRTC 1.0 PR w3c/webrtc-pc#758
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants