Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

facingMode et al are non-nullable and cannot "return null". #796

Merged
merged 1 commit into from Sep 29, 2016
Merged

facingMode et al are non-nullable and cannot "return null". #796

merged 1 commit into from Sep 29, 2016

Conversation

jan-ivar
Copy link
Member

Fix for language discovered in #305 (comment).

@stefhak
Copy link
Contributor

stefhak commented Sep 18, 2016

Thanks for fixing this. LGTM.

@alvestrand
Copy link
Contributor

LGTM. A function returns null; a dictionary member is missing.

@stefhak
Copy link
Contributor

stefhak commented Sep 19, 2016

BTW, it strikes me that a sentence similar to this one should probably be present in the -fromelement and -screen-share specs.

@alvestrand alvestrand merged commit 84c0fe2 into w3c:master Sep 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jan-ivar @stefhak @alvestrand