Throw InvalidAccessError if removeTrack is called with invalid sender #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der. Fixes issue w3c#727. "invalid sender" refers to one that was created by another RTCPeerConnection. The working group agreed to this at TPAC 2016.
|
Note that since transceivers never go away, senders also never go away. Which means the check for "was this sender created by this peer connection?" simplifies to "is this sender in this peer connection's set of senders?" |
mparis
approved these changes
Oct 3, 2016
|
LGTM. Good to get rid of the old language that assumed that senders get removed from the 'sender set'. |
taylor-b
pushed a commit
to taylor-b/webrtc-pc
that referenced
this pull request
Oct 7, 2016
In PR w3c#844, the intent was to throw an exception when the sender wasn't created by the connection on which the method was called. And the assumption was that senders are never removed, so the algorithm can simply check if it's in the connection's set of senders. But something I didn't consider is that rollbacks are able to remove transceivers (and thus senders). So more clarity is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #727. "invalid sender" refers to one that was created by
another RTCPeerConnection. The working group agreed to this at TPAC
2016.