Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rejecting Promises with a closed/closing stream #14

Closed
shampson opened this issue May 31, 2018 · 0 comments
Closed

Rejecting Promises with a closed/closing stream #14

shampson opened this issue May 31, 2018 · 0 comments
Labels
PR exists A pull request has been submitted

Comments

@shampson
Copy link
Collaborator

shampson commented May 31, 2018

There's nothing about rejecting Promises, but this seems to be appropriate when the [[Readable]] or [[Writable]] slots transition from true to false. Here's the cases I see:

Rejecting WaitForReadable Promises

  • If reset() is called we can no longer read
  • If the stream transitions to the closed state we can no longer read
  • If the stream transitions to the closing state we can no longer read (receiving a FIN or RST_STREAM)

Rejecting WaitForWritable Promises

  • If closed() or reset() is called then we can no longer write
  • If the stream transitions to the closed state then we can no longer write
  • If the stream transitions to the closing state we can no longer write when receiving a RST_STREAM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR exists A pull request has been submitted
Projects
None yet
Development

No branches or pull requests

2 participants