Update examples and tweak API #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboba
approved these changes
May 20, 2024
pthatcher
commented
May 28, 2024
| readonly attribute unsigned long long? remoteSendTimestamp; | ||
|
|
||
| // OPTIONAL: Extra information that may be useful to know | ||
| readonly attribute DOMHighResTimeStamp receivedTime; | ||
| readonly attribute unsigned long sequenceNumberRolloverCount; | ||
|
|
||
| void setHeaderExtension(RtpHeaderExtension); |
There was a problem hiding this comment.
Make RtpPacket immutable and
let init = rtpPacket.init();
init.audioLevel = 10;
let mutatedRtpPacket = new RtpPacket(init);
or
let mutatedRtpPacket = new RtpPacket({
audioLevel: 10,
..rtpPacket,
});
or
let builder= rtpPacket.mutate();
builder.setAudioLevel(10);
let mutatedRtpPacket = mutator.build();
But the 2nd might not work with seqnum, and the 1st needs better names (and can't have methods). And the 3rd requires a new interface (so we have RtpPacket, RtpPacketInit, and RtpPacketBuilder/Mutator).
There was a problem hiding this comment.
If we land #31, this will be a little simpler, as there will be fewer fields, and no issues with inconsistent updates between eg audioLevel & headerExtensions.
pthatcher
commented
May 28, 2024
| rtpReceiveStream.receiveRtp(rtpPacket); | ||
| } | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Hmmm... might not work with the fact that we can't set seqnums
|
Related: #40 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, added these APIs: