-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RoundTripTime not defined when the underlying stream can't calculate it #180
Comments
@jesup: I think at the TPAC the decision was to use undefined if it is not measured. and 0 or any good starting value, if it is measuring but doe not have a measurement. I think -1 would make sense in this case. |
for deployments when no RTCP RR is sent/received (some legacy middleboxes do not send RTCP RRs, although send RTCP SRs), I think it will remain -1. |
We just moved roundTripTime to the |
If we don't have a value for it (because we haven't exchanged packets) then it should be undefined, not -1. |
Again, there should never be a need for either, since the whole dictionary will be absent in that case, and the associate stats dictionary's That's my best reading of the spec, and is how Firefox implements it. |
Oh right, that makes sense. |
@jesup schooled me on the round-trip time calculation, and it turns out it can't be calculated until an RR comes in with data based off a remotely-receivecd SR. In other words, not necessarily the first RR. So based on the same reading of the stats spec I mentioned above I think it makes sense for the |
Yes. |
I agree - missing/undefined |
I will fix it. |
RoundTripTime can only be calculated after an exchange of RTCP packets with the relevant information. Until then, it's not possible to calculate. What should be RoundTripTime have before we know the time? 0? undefined? null? And what will be the impact on existing applications if we choose something like undefined or null?
The text was updated successfully, but these errors were encountered: