Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do when a function is not supported should be clear #20

Closed
alvestrand opened this issue Oct 28, 2015 · 4 comments
Closed

What to do when a function is not supported should be clear #20

alvestrand opened this issue Oct 28, 2015 · 4 comments
Assignees

Comments

@alvestrand
Copy link
Contributor

There are a number of counters (for example sliCount) that are likely to be:

  1. Only implemented for some track types (video in this case)
  2. Only implemented by some platforms
    It should be clear what the value of this should be when it's not going to be handled:
  • zero always for a platform that does not count them?
  • missing for a platform that doesn't count them?
  • zero or missing for a track where it's not appliciable? (I think missing)
@vr000m
Copy link
Contributor

vr000m commented Oct 28, 2015

  1. I think we should clarify that this is for video
  2. missing makes most sense. Because 0 has a semantic meaning , i.e., no losses. In XR blocks, we've used 0xff to represent measurement unavailable, but in dictionaries, skipping the key when not measured seems like good advice.

@alvestrand alvestrand self-assigned this Mar 21, 2016
@alvestrand
Copy link
Contributor Author

Think we should be consistent across all data types - so let it be part of the introduction.

@vr000m
Copy link
Contributor

vr000m commented May 9, 2016

Special note for jitter as zero has semantic meaning.

@vr000m
Copy link
Contributor

vr000m commented Sep 23, 2016

TPAC16 decisions:

“” for strings, 0 and -1 for integers are all legal values under some circumstances.

Proposal:

  • Unsupported stats are not present in the dictionary
  • Stats that haven’t started counting are present with a suitable starting value
  • Special considerations when 0 is a suitable value (such as RTT)!

alvestrand added a commit that referenced this issue Oct 12, 2016
Adds design guidance on adding stats, on stats values when not relevant,
and on stats lifetimes.

Closes #20

Note: #20 says that we need to note that zero is a valid value for jitter,
so can't be used as an initial value for "not set yet". This isn't added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants