-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should track also contain RTCRtpReceiver stats? #361
Comments
When we switched from monitoring tracks to monitoring senders, the thought was that the tracks were there for legacy purposes; it's actually a bit hard to get them to function correctly. So we'd prefer that people use stats from senders and receivers, respectively. |
For backwards compatible reasons we should have a "track" for the attachment to a receiver. Because a receiver has a life-long attachment, this would always be a copy of the "receiver" stats object. But without such language, you would not find the receiving tracks as a "track". |
@alvestrand Yes we want to remove "track" altogether, but it would be strange to have the backwards compatible "track" in the sender case but not the receiver case. If the spec was implemented properly as written today, all the receiver "tracks" would disappear. We could move it to the Obsolete stats section though to be clear about this being old. |
if we are moving "tracks" Obsolete stats section then we could do the same for "stream". |
Yes that sounds like a good idea to me. If we still want to expose stream identifiers that more properly belongs to the sender and receiver state as a sequence<DOMString> streamIdentifiers. The webrtc-pc spec has shied away from streams for a while now so these might not be very interesting but that would be the right way to do it. |
Firefox has not yet implement But we should check with @vr000m who I believe was the proponent of keeping |
👍 I've filed #365.
Not necessarily. trackIdentifier is different from trackId. trackIdentifier is |
From the discussion above, it seems we are leaning on a Yes, there must be receiver stats. It is an orthogonal discussion if the track stats should be deprecated. We can make some tests on replace track, simulcast, and SVC tracks and observe if it breaks anything. If senders cover the trackability/diagnostics in these situations, I am happy to get rid of the tracks. |
Related to #402 |
TPAC decision: Add receiving "track" stats to the obsolete section. |
Currently definition for track is defined as
Contains statistics related to a specific MediaStreamTrack's attachment to an RTCRtpSender and the corresponding media-level metrics. It is accessed by either RTCSenderVideoTrackAttachmentStats or RTCSenderAudioTrackAttachmentStats, both inherited from RTCMediaHandlerStats.
The monitored "track" object is deleted when the sender it reports on has its "track" value changed to no longer refer to the same track.
So my question is should it contain both RTCRtpSender and RTCRtpReciever
The text was updated successfully, but these errors were encountered: