-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTCVideoSourceStats.framesPerSecond should be a double #540
Comments
as other definitions of framesPerSecond members in other stat objects close w3c#540
as other definitions of framesPerSecond members in other stat objects close w3c#540
Wonder if we did this right. The definitional text for these entries says that it's a count, not a calculation ("number of frames ... in the last second"). Suggest to leave it as is, but wanted to record the doubt. |
This is not only a problem with RTCVideoSourceStats.framesPerSecond, but also with RTCInboundRtpStreamStats, RTCOutboundRtpStreamStats. |
I think the intention of the metric to return the latest Or current FPS for frames received in the last second. Much like round trip time, which also returns the latest RTT measurements. So this is invariant to how often you call getStats, it would always return the current value. Otherwise, I'd recommend that we use the delta of framesSent and/or framesDecoded between two getStats API calls to calculate that interval's FPS. |
All the fields
framesPerSecond
as defined asdouble
except inRTCVideoSourceStats
where it is defined as an unsigned long.The text was updated successfully, but these errors were encountered: