Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTCDataChannelStats.dataChannelIdentifier should be unsigned short #541

Closed
dontcallmedom opened this issue Feb 3, 2020 · 0 comments
Closed

RTCDataChannelStats.dataChannelIdentifier should be unsigned short #541

dontcallmedom opened this issue Feb 3, 2020 · 0 comments
Labels
PR exists

Comments

@dontcallmedom
Copy link
Member

aligned with the definition of RTCDataChannel.id in WebRTC
dontcallmedom added a commit to dontcallmedom/webrtc-stats that referenced this issue Feb 4, 2020
@dontcallmedom
Make dataChannelIdentifier an unsigned short
ff6129f 
Same as the [definition of  in WebRTC](https://w3c.github.io/webrtc-pc/webrtc.html#dom-rtcdatachannel-id)
close w3c#541
dontcallmedom added a commit to dontcallmedom/webrtc-stats that referenced this issue Feb 5, 2020
@dontcallmedom
Make dataChannelIdentifier an unsigned short
706f344 
Same as the [definition of  in WebRTC](https://w3c.github.io/webrtc-pc/webrtc.html#dom-rtcdatachannel-id)
close w3c#541
@vr000m vr000m closed this as completed in 9c60a98 Feb 5, 2020
@vr000m vr000m mentioned this issue Apr 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PR exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dontcallmedom