Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear pliCount, firCount, and nackCount for outbound-rtp #658

Closed
k0nserv opened this issue Aug 22, 2022 · 1 comment · Fixed by #663
Closed

Unclear pliCount, firCount, and nackCount for outbound-rtp #658

k0nserv opened this issue Aug 22, 2022 · 1 comment · Fixed by #663

Comments

@k0nserv
Copy link

k0nserv commented Aug 22, 2022

For outbound-rtp, pliCount, nackCount, and firCount in particular, the spec says that the "count" is calculated through some method defined in various RFCs. However those RFCs don't seem to define any such method.

For example, for nackCount the spec says:

Count the total number of Negative ACKnowledgement (NACK) packets sent by this receiver.
Calculated as defined in [RFC4585] section 6.2.1.

However, RFC4584 6.2.1 does not specify anything about calculating this count as far as I can tell.

Please advise

@fippo
Copy link
Contributor

fippo commented Aug 22, 2022

Nice catch!
For PLI and FIR this is simply the count of the RTCP packets with the types defined in those sections.

For NACK it is a bit more complicated since a NACK packet can contain but a base sequence number as well as at least one bitmask describing 16 additional sequence numbers relative to the base one.
this in libwebrtc describes it as number of NACK packets but digging a bit further shows this is incrementing the count for each lost packet.

fippo added a commit to fippo/webrtc-stats that referenced this issue Aug 31, 2022
fippo added a commit to fippo/webrtc-stats that referenced this issue Sep 26, 2022
fippo added a commit to fippo/webrtc-stats that referenced this issue Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants