Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When are RTP stream stats created? #667

Closed
henbos opened this issue Sep 6, 2022 · 6 comments
Closed

When are RTP stream stats created? #667

henbos opened this issue Sep 6, 2022 · 6 comments
Assignees

Comments

@henbos
Copy link
Collaborator

henbos commented Sep 6, 2022

Originally part of issue #643. See also When are RTP streams destroyed?

Spec currently says when the SSRC is known. Seems to match implementation.

Proposal: Keep it this way

@fippo
Copy link
Contributor

fippo commented Sep 6, 2022

we need to resolve #619, no?

@henbos
Copy link
Collaborator Author

henbos commented Sep 7, 2022

we need to resolve #619, no?

If we decide to keep the spec as-is, yes. Let's get agreements and clarifications first.

@henbos henbos self-assigned this Sep 7, 2022
henbos added a commit to henbos/webrtc-stats that referenced this issue Sep 7, 2022
@henbos
Copy link
Collaborator Author

henbos commented Sep 7, 2022

Slight nuance change in #671 to match Chromium. The alternative would be to update the implementation to hide RTP stats objects until packetsSent > 0 but with today's implementation the criteria for whether or not to expose an RTP stream stats is whether or not the SSRC is known (not whether or not packets are flowing). And the SSRC is known at different points in time depending on whether or not the SSRC was signalled.

@henbos
Copy link
Collaborator Author

henbos commented Sep 7, 2022

Update: I think we should abandon the PR and the spec's sentence exactly as-is.

@henbos
Copy link
Collaborator Author

henbos commented Sep 12, 2022

TPAC: Decision to go in this direction, but some concerns about backwards compatibility, so implementations may want to add a killswitch or experiment.

@henbos henbos removed the PR exists label Sep 13, 2022
@henbos
Copy link
Collaborator Author

henbos commented Sep 13, 2022

With the outcome that implementations should be updated, I think we can close this spec issue. If there are any implementation/shipping hurdles that warrant revisiting this we can always re-open it in the future, but closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants