Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change playoutdelay to jitterbuffertarget #753

Closed
bdrtc opened this issue Apr 21, 2023 · 2 comments
Closed

Change playoutdelay to jitterbuffertarget #753

bdrtc opened this issue Apr 21, 2023 · 2 comments

Comments

@bdrtc
Copy link
Contributor

bdrtc commented Apr 21, 2023

As the playoutDelay changed to jitterbuffertarget in this PR , playoutDelay used in webrtc-stats should be changed accordingly.

@henbos
Copy link
Collaborator

henbos commented Apr 21, 2023

jitterBufferDelay is the actual delay, the total time spent for each sample emitted by the jitter buffer. That does not need to change.

The reason the actual delay may be different than the target delay, jitterBufferTargetDelay, is that when the target changes we accelerate or decelerate samples to avoid glitches. The RTCRtpReceiver.jitterBufferTarget API sets the desired target of the app. The reason why the API target and the current target may be different is due to, as the API describes, there could be network conditions or resource constraints that make the UA not able to achieve it right now.

And the jitterBufferMinimumDelay is just exposing the internal view of what the minimum delay could be.

The way I see it, there are no webrtc-stats changes needed and it all makes sense. @jan-ivar

@henbos
Copy link
Collaborator

henbos commented Apr 21, 2023

Sorry ignore me, I thought you wanted to rename the stats, but you just wanted to update a reference. Yes let's do that

henbos added a commit that referenced this issue Apr 21, 2023
* fixs #753 change playout delay to jitterbuffertarget

* add prefix of "dom"

* Update webrtc-stats.html

Co-authored-by: henbos <hbos@google.com>

* Update webrtc-stats.html

Co-authored-by: henbos <hbos@google.com>

---------

Co-authored-by: 何超 <hechao.0520@bytedance.com>
Co-authored-by: henbos <hbos@google.com>
@bdrtc bdrtc closed this as completed Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants