Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is codec.sdpFmtpLine present when there is no fmtp line in the SDP? #779

Closed
fippo opened this issue Jan 24, 2024 · 2 comments · Fixed by #780
Closed

Is codec.sdpFmtpLine present when there is no fmtp line in the SDP? #779

fippo opened this issue Jan 24, 2024 · 2 comments · Fixed by #780

Comments

@fippo
Copy link
Contributor

fippo commented Jan 24, 2024

Which is typically the case for VP8 which has no parameters. In Chrome this leads to
image
while sdpFmtpLine is defined as

DOMString     sdpFmtpLine;

here.

It seems like this should only exist when the codec has a fmtp line? No code changes required but we might need some WPT updates.

@fippo fippo changed the title Is codec.sdpFmtpLine present when there is no sdpFmtpLine in the SDP? Is codec.sdpFmtpLine present when there is no fmtp line in the SDP? Jan 24, 2024
@alvestrand
Copy link
Contributor

It's a dictionary, so omitting members is allowed, and I think it should be required to omit it when there is no fmtp line. (If there's "a=fmtp:96:" in the SDP, there should be an empty string there, of course.)

@fippo
Copy link
Contributor Author

fippo commented Jan 24, 2024

oh we have that special-case of empty fmtp line for stats too courtesy of @dontcallmedom!

fippo added a commit to fippo/webrtc-stats that referenced this issue Jan 25, 2024
henbos pushed a commit that referenced this issue Jan 25, 2024
* clarify that sdpFmtpLine may not be there

fixes #779

* remove JSEP alias

* Update webrtc-stats.html

Co-authored-by: Philipp Hancke <fippo@goodadvice.pages.de>

---------

Co-authored-by: Harald Alvestrand <hta+github@alvestrand.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants