Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding total consent interval #214

Closed
wants to merge 1 commit into from
Closed

adding total consent interval #214

wants to merge 1 commit into from

Conversation

vr000m
Copy link
Contributor

@vr000m vr000m commented May 10, 2017

fixes #63.

@vr000m vr000m requested review from henbos and taylor-b May 10, 2017 12:05
henbos
henbos approved these changes May 10, 2017
View reviewed changes
Copy link
Collaborator

@henbos henbos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@henbos
Copy link
Collaborator

henbos commented May 10, 2017

If lastResponseTimestamp of #213 is not enough of a heartbeat metric.

@taylor-b
Copy link
Contributor

If we're adding lastRequestTimestamp, it would be more consistent to add firstRequestTimestamp rather than sumCheckInterval. Because lastRequestTimestamp - firstRequestTimestamp would be equivalent to sumCheckInterval.

@vr000m
Copy link
Contributor Author

vr000m commented May 11, 2017

@taylor-b I am fine with your change, is the firstRequestTimestamp, the timestamp of the first connectivity check?

@henbos could you do taylor's change as part of your PR #213, so that I can just close this one?

@henbos henbos mentioned this pull request May 11, 2017
Merged
@henbos
Copy link
Collaborator

henbos commented May 11, 2017

SGTM

@henbos henbos closed this May 11, 2017
@vr000m vr000m deleted the issue-63-consent-and-circuit-breaker branch June 14, 2017 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henbos henbos henbos approved these changes

@taylor-b taylor-b Awaiting requested review from taylor-b

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing consent interval in RTCIceCandidatePairStats
3 participants
@vr000m @henbos @taylor-b