Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTCMediaStreamTrackStats.concealedAudibleSamples added. #215

Closed
wants to merge 3 commits into from
Closed

RTCMediaStreamTrackStats.concealedAudibleSamples added. #215

wants to merge 3 commits into from

Conversation

henbos
Copy link
Collaborator

@henbos henbos commented May 10, 2017

Fixes #202

@henbos
Copy link
Collaborator Author

henbos commented May 10, 2017

Is it OK to have the user agent decide what is considered audible?

@vr000m vr000m requested review from jan-ivar and aboba May 10, 2017 13:46
jan-ivar
jan-ivar approved these changes May 10, 2017
View reviewed changes
Copy link
Member

@jan-ivar jan-ivar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. AFAIK we generally shy away from specifying quality or performance related behavior when it comes to media output. @jesup what do you think?

vr000m
vr000m reviewed May 11, 2017
View reviewed changes
webrtc-stats.html Outdated
(see <a>concealedSamples</a>) that was played out during an audible portions of the
stream. Audible means that the received audio is not considered background noise or
silence by the user agent. It is up to the implementation to determine what is
considered background noise.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add: The value is set to undefined for user-agents that do not implement this metric.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@vr000m
Copy link
Contributor

vr000m commented May 11, 2017 •
edited

@jan-ivar should we wait for @jesup's feedback or are we good to go?

My challenge as yet is the definition for "audible", and missing a reference for it.

@vr000m
Copy link
Contributor

vr000m commented Sep 27, 2017

Discuss this at TPAC, because we do not seem to move forward on this. Especially since the metric is not standardised anywhere . @dontcallmedom @aboba @stefhak

@vr000m
Copy link
Contributor

vr000m commented Oct 20, 2017

@jesup @aboba bump! If you can have a look at this one before TPAC, it would definitely speed up discussion.

@vr000m
Copy link
Contributor

vr000m commented Nov 22, 2017

TPAC decision was if there is a citable reference then lets move ahead, else this PR can be closed.

@henbos
Copy link
Collaborator Author

henbos commented Dec 5, 2017

We don't have a citable reference. Sounds like a case for the incubator spec.

@henbos henbos closed this Dec 5, 2017
@henbos henbos mentioned this pull request Dec 8, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vr000m vr000m vr000m left review comments

@jan-ivar jan-ivar jan-ivar approved these changes

@aboba aboba Awaiting requested review from aboba

Assignees
No one assigned
Labels
List discussion needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@henbos @vr000m @jan-ivar