Remove most unimplemented stats #622

henbos · 2022-04-07T12:06:37Z

One of the steps needed for #621.

AFTER THIS PR HAS BEEN APPROVED BUT BEFORE LANDING IT:
Create a corresponding webrtc-provisional-stats PR adding these metrics to that document instead.

The metrics removed in this PR are those not implemented according to:

Metrics are removed regardless if they are easy or hard to implement and regardless of their usefulness - this is entirely based on implementers' interest.

Everything is not covered in this PR, other stuff:

Stuff implemented but failing in the WPT:

rid: This is implemented, but the WPT does not trigger simulcast.
echoReturnLoss/echoReturnLossEnhancement: Manually verified that values show up in a real call.
issuerCertificateId: No idea if it's possible to trigger this code path or how to do it, but there is code that maybe fills this in.

Preview | Diff

henbos · 2022-04-07T12:07:33Z

Step one - please take a look, Harald and Varun

solmaks · 2022-04-07T13:11:45Z

The metrics removed in this PR are those not implemented according to wpt.fyi.

Isn't the reason for WPT showing some of them as unimplemented related to the nature of some metrics? Such as outbound-rtp.rid being only available when simulcast envelope is provisioned through RTCRtpTransceiver, which referenced WPT is not doing.

fippo · 2022-04-07T13:29:42Z

estimatedPlayoutTimestamp is implemented for sure (and rid is as well)

henbos · 2022-04-07T13:42:34Z

Good catches, thanks for reviewing! "Fort och fel" as we say in swedish.

I've abandoned the PR that removed rid (because it's implemented).
I've restored estimatedPlayoutTimestamp so that it's not removed in this PR (because it's implemented).

henbos · 2022-04-07T13:43:21Z

The intent is only to remove things that have not been implemented by any browser, please let me know if you find any other mistakes

henbos · 2022-04-07T15:05:49Z

issuerCertificateId: No idea if it's possible to trigger this code path or how to do it, but there is code that maybe fills this in.

With regards to this one, perhaps we should remove it? Maybe it's like the RTCP transport one: spec allows it, but nobody does it, and path is untested.

webrtc-stats.html

fippo · 2022-04-07T15:55:51Z

webrtc-stats.html

@@ -3844,8 +3110,6 @@ <h3>
             DOMString                protocol;
             required RTCIceCandidateType candidateType;
             long                     priority;
-             DOMString                url;
-             DOMString                relayProtocol;


both url and relayProtocol are implemented

Needs better tests...

we should restore these.

webrtc-stats.html

fippo · 2022-04-18T10:51:26Z

https://w3c.github.io/webrtc-stats/#dom-rtctransportstats-tlsgroup -- just found this reviewing. I don't see much utility and it is not implemented in Chrome so i'd 👍 removing it

henbos

Ready to merge, just need to create a PR that adds these to provisional spec

henbos · 2022-06-08T14:53:00Z

webrtc-stats.html

@@ -3844,8 +3110,6 @@ <h3>
             DOMString                protocol;
             required RTCIceCandidateType candidateType;
             long                     priority;
-             DOMString                url;
-             DOMString                relayProtocol;


webrtc-stats.html

henbos · 2022-06-09T11:10:27Z

The corresponding metrics were just added to provisional, unblocking this PR:
w3c/webrtc-provisional-stats#27

w3c/webrtc-stats#622 dropped a number of unimplemented Identifiers for WebRTC's Statistics API features.

w3c/webrtc-stats#622 dropped a number of unimplemented Identifiers for WebRTC's Statistics API features. Related BCD change: mdn/browser-compat-data#16748

w3c/webrtc-stats#622 dropped a number of unimplemented Identifiers for WebRTC's Statistics API features.

* Drop some unimplemented webrtc-stats features w3c/webrtc-stats#622 dropped a number of unimplemented Identifiers for WebRTC's Statistics API features. Related BCD change: mdn/browser-compat-data#16748 * Drop unimplemented stats from RTCIceCandidatePairStats & RTCRtpStreamStats pages

While the test was disabled a lot of metrics were removed from the webrtc-stats spec, hence a lot less FAIL lines. The diffs reflect: - w3c/webrtc-stats#622 - mid and trackIdentifier being implemented - jitterBufferMinimumDelay: https://webrtc-review.googlesource.com/c/src/+/262770 Bug: webrtc:14147 Change-Id: I6e66e1f11ce57da88058313f2a0168e56c40d45a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3791113 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@chromium.org> Auto-Submit: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/main@{#1029691}

The mass removal of RTC items in removeTypes reflects w3c/webrtc-stats#622 but also the much better implementation status.

While the test was disabled a lot of metrics were removed from the webrtc-stats spec, hence a lot less FAIL lines. The diffs reflect: - w3c/webrtc-stats#622 - mid and trackIdentifier being implemented - jitterBufferMinimumDelay: https://webrtc-review.googlesource.com/c/src/+/262770 Bug: webrtc:14147 Change-Id: I6e66e1f11ce57da88058313f2a0168e56c40d45a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3791113 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@chromium.org> Auto-Submit: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/main@{#1029691} NOKEYCHECK=True GitOrigin-RevId: d5425a8c0bc8b9e85dfd7addb47f20123e969f34

removed in w3c/webrtc-stats#622 (comment) BUG=None Change-Id: I8b2d8b2fa7776607bc863d6888a6ddb655dfac2c

removed in w3c/webrtc-stats#622 (comment) BUG=None Change-Id: I8b2d8b2fa7776607bc863d6888a6ddb655dfac2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5018488 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1223532}

…d tlsGroup stats, a=testonly Automatic update from web-platform-tests webrtc wpt: remove test for unimplemented tlsGroup stats removed in w3c/webrtc-stats#622 (comment) BUG=None Change-Id: I8b2d8b2fa7776607bc863d6888a6ddb655dfac2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5018488 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1223532} -- wpt-commits: 8bb6ce81118b954e6af5870cbf770de3f6dee01b wpt-pr: 43104

…d tlsGroup stats, a=testonly Automatic update from web-platform-tests webrtc wpt: remove test for unimplemented tlsGroup stats removed in w3c/webrtc-stats#622 (comment) BUG=None Change-Id: I8b2d8b2fa7776607bc863d6888a6ddb655dfac2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5018488 Reviewed-by: Henrik Boström <hboschromium.org> Commit-Queue: Philipp Hancke <phanckemicrosoft.com> Cr-Commit-Position: refs/heads/main{#1223532} -- wpt-commits: 8bb6ce81118b954e6af5870cbf770de3f6dee01b wpt-pr: 43104 UltraBlame original commit: 9576c917f0f49d63e5a36c4216b8d77fefa8a90c

Delete most stats

c7c3fea

henbos requested review from alvestrand and vr000m April 7, 2022 12:07

solmaks mentioned this pull request Apr 7, 2022

Remove outbound-rtp.rid #623

Closed

Restore estimatedPlayoutTimestamp

e7a54bb

henbos mentioned this pull request Apr 7, 2022

Map out implementation status of getStats and make a plan #595

Closed

fippo reviewed Apr 7, 2022

View reviewed changes

webrtc-stats.html Show resolved Hide resolved

fippo reviewed Apr 7, 2022

View reviewed changes

webrtc-stats.html Show resolved Hide resolved

fippo reviewed Apr 7, 2022

View reviewed changes

webrtc-stats.html Show resolved Hide resolved

fippo reviewed Apr 7, 2022

View reviewed changes

webrtc-stats.html Show resolved Hide resolved

fippo reviewed Apr 7, 2022

View reviewed changes

webrtc-stats.html Outdated Show resolved Hide resolved

fippo reviewed Apr 7, 2022

View reviewed changes

webrtc-stats.html Show resolved Hide resolved

alvestrand added the Editors can integrate label May 3, 2022

henbos added 2 commits June 8, 2022 16:47

Rebase

4c2d266

Restored some metrics that should not have been removed

ed8707a

henbos commented Jun 8, 2022

View reviewed changes

henbos commented Jun 9, 2022

View reviewed changes

webrtc-stats.html Show resolved Hide resolved

henbos commented Jun 9, 2022

View reviewed changes

webrtc-stats.html Show resolved Hide resolved

henbos commented Jun 9, 2022

View reviewed changes

webrtc-stats.html Outdated Show resolved Hide resolved

henbos commented Jun 9, 2022

View reviewed changes

webrtc-stats.html Show resolved Hide resolved

henbos commented Jun 9, 2022

View reviewed changes

webrtc-stats.html Show resolved Hide resolved

More restoration

eaeb0b3

henbos mentioned this pull request Jun 9, 2022

Move most unimplemented stats to provisional w3c/webrtc-provisional-stats#27

Merged

henbos added 2 commits June 9, 2022 13:12

Revive sentence

75f92c2

Fix errors

7be489f

henbos merged commit 109aecf into w3c:main Jun 9, 2022

sideshowbarker added a commit to mdn/browser-compat-data that referenced this pull request Jun 21, 2022

Drop some unimplemented webrtc-stats features

2396c08

w3c/webrtc-stats#622 dropped a number of unimplemented Identifiers for WebRTC's Statistics API features.

sideshowbarker mentioned this pull request Jun 21, 2022

Drop some unimplemented webrtc-stats features mdn/browser-compat-data#16748

Merged

sideshowbarker mentioned this pull request Jun 21, 2022

Drop some unimplemented webrtc-stats features mdn/content#17486

Merged

queengooborg pushed a commit to mdn/browser-compat-data that referenced this pull request Jun 21, 2022

Drop some unimplemented webrtc-stats features (#16748)

f30149f

w3c/webrtc-stats#622 dropped a number of unimplemented Identifiers for WebRTC's Statistics API features.

henbos mentioned this pull request Aug 30, 2022

Clarify which metrics are only applicable to a particular kind according to implementation interest. #660

Open

saschanaz added a commit to saschanaz/types-web that referenced this pull request Sep 17, 2022

Manually update to webref/idl@3.17.0

f12440c

The mass removal of RTC items in removeTypes reflects w3c/webrtc-stats#622 but also the much better implementation status.

saschanaz added a commit to saschanaz/types-web that referenced this pull request Sep 17, 2022

Manually update to webref/idl@3.17.0

209bd72

The mass removal of RTC items in removeTypes reflects w3c/webrtc-stats#622 but also the much better implementation status.

saschanaz mentioned this pull request Sep 17, 2022

Manually update to webref/idl@3.17.0 microsoft/TypeScript-DOM-lib-generator#1400

Merged

chromium-wpt-export-bot mentioned this pull request Nov 12, 2023

webrtc wpt: remove test for unimplemented tlsGroup stats web-platform-tests/wpt#43104

Merged

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Nov 12, 2023

webrtc wpt: remove test for unimplemented tlsGroup stats

5e78570

removed in w3c/webrtc-stats#622 (comment) BUG=None Change-Id: I8b2d8b2fa7776607bc863d6888a6ddb655dfac2c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove most unimplemented stats #622

Remove most unimplemented stats #622

henbos commented Apr 7, 2022 •

edited by pr-preview bot

Loading

henbos commented Apr 7, 2022

solmaks commented Apr 7, 2022 •

edited

Loading

fippo commented Apr 7, 2022

henbos commented Apr 7, 2022

henbos commented Apr 7, 2022

henbos commented Apr 7, 2022

fippo Apr 7, 2022

alvestrand May 3, 2022

vr000m May 17, 2022

henbos Jun 8, 2022

fippo commented Apr 18, 2022 •

edited

Loading

henbos left a comment

henbos Jun 8, 2022

henbos commented Jun 9, 2022

Remove most unimplemented stats #622

Remove most unimplemented stats #622

Conversation

henbos commented Apr 7, 2022 • edited by pr-preview bot Loading

henbos commented Apr 7, 2022

solmaks commented Apr 7, 2022 • edited Loading

fippo commented Apr 7, 2022

henbos commented Apr 7, 2022

henbos commented Apr 7, 2022

henbos commented Apr 7, 2022

fippo Apr 7, 2022

Choose a reason for hiding this comment

alvestrand May 3, 2022

Choose a reason for hiding this comment

vr000m May 17, 2022

Choose a reason for hiding this comment

henbos Jun 8, 2022

Choose a reason for hiding this comment

fippo commented Apr 18, 2022 • edited Loading

henbos left a comment

Choose a reason for hiding this comment

henbos Jun 8, 2022

Choose a reason for hiding this comment

henbos commented Jun 9, 2022

henbos commented Apr 7, 2022 •

edited by pr-preview bot

Loading

solmaks commented Apr 7, 2022 •

edited

Loading

fippo commented Apr 18, 2022 •

edited

Loading