-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove most unimplemented stats #622
Conversation
Step one - please take a look, Harald and Varun |
Isn't the reason for WPT showing some of them as unimplemented related to the nature of some metrics? Such as outbound-rtp.rid being only available when simulcast envelope is provisioned through RTCRtpTransceiver, which referenced WPT is not doing. |
estimatedPlayoutTimestamp is implemented for sure (and rid is as well) |
Good catches, thanks for reviewing! "Fort och fel" as we say in swedish.
|
The intent is only to remove things that have not been implemented by any browser, please let me know if you find any other mistakes |
With regards to this one, perhaps we should remove it? Maybe it's like the RTCP transport one: spec allows it, but nobody does it, and path is untested. |
webrtc-stats.html
Outdated
@@ -3844,8 +3110,6 @@ <h3> | |||
DOMString protocol; | |||
required RTCIceCandidateType candidateType; | |||
long priority; | |||
DOMString url; | |||
DOMString relayProtocol; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both url and relayProtocol are implemented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs better tests...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should restore these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restored
https://w3c.github.io/webrtc-stats/#dom-rtctransportstats-tlsgroup -- just found this reviewing. I don't see much utility and it is not implemented in Chrome so i'd 👍 removing it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge, just need to create a PR that adds these to provisional spec
webrtc-stats.html
Outdated
@@ -3844,8 +3110,6 @@ <h3> | |||
DOMString protocol; | |||
required RTCIceCandidateType candidateType; | |||
long priority; | |||
DOMString url; | |||
DOMString relayProtocol; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restored
The corresponding metrics were just added to provisional, unblocking this PR: |
w3c/webrtc-stats#622 dropped a number of unimplemented Identifiers for WebRTC's Statistics API features.
w3c/webrtc-stats#622 dropped a number of unimplemented Identifiers for WebRTC's Statistics API features. Related BCD change: mdn/browser-compat-data#16748
w3c/webrtc-stats#622 dropped a number of unimplemented Identifiers for WebRTC's Statistics API features. Related BCD change: mdn/browser-compat-data#16748
w3c/webrtc-stats#622 dropped a number of unimplemented Identifiers for WebRTC's Statistics API features.
* Drop some unimplemented webrtc-stats features w3c/webrtc-stats#622 dropped a number of unimplemented Identifiers for WebRTC's Statistics API features. Related BCD change: mdn/browser-compat-data#16748 * Drop unimplemented stats from RTCIceCandidatePairStats & RTCRtpStreamStats pages
While the test was disabled a lot of metrics were removed from the webrtc-stats spec, hence a lot less FAIL lines. The diffs reflect: - w3c/webrtc-stats#622 - mid and trackIdentifier being implemented - jitterBufferMinimumDelay: https://webrtc-review.googlesource.com/c/src/+/262770 Bug: webrtc:14147 Change-Id: I6e66e1f11ce57da88058313f2a0168e56c40d45a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3791113 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@chromium.org> Auto-Submit: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/main@{#1029691}
The mass removal of RTC items in removeTypes reflects w3c/webrtc-stats#622 but also the much better implementation status.
The mass removal of RTC items in removeTypes reflects w3c/webrtc-stats#622 but also the much better implementation status.
While the test was disabled a lot of metrics were removed from the webrtc-stats spec, hence a lot less FAIL lines. The diffs reflect: - w3c/webrtc-stats#622 - mid and trackIdentifier being implemented - jitterBufferMinimumDelay: https://webrtc-review.googlesource.com/c/src/+/262770 Bug: webrtc:14147 Change-Id: I6e66e1f11ce57da88058313f2a0168e56c40d45a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3791113 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@chromium.org> Auto-Submit: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/main@{#1029691} NOKEYCHECK=True GitOrigin-RevId: d5425a8c0bc8b9e85dfd7addb47f20123e969f34
removed in w3c/webrtc-stats#622 (comment) BUG=None Change-Id: I8b2d8b2fa7776607bc863d6888a6ddb655dfac2c
removed in w3c/webrtc-stats#622 (comment) BUG=None Change-Id: I8b2d8b2fa7776607bc863d6888a6ddb655dfac2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5018488 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1223532}
removed in w3c/webrtc-stats#622 (comment) BUG=None Change-Id: I8b2d8b2fa7776607bc863d6888a6ddb655dfac2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5018488 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1223532}
removed in w3c/webrtc-stats#622 (comment) BUG=None Change-Id: I8b2d8b2fa7776607bc863d6888a6ddb655dfac2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5018488 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1223532}
…d tlsGroup stats, a=testonly Automatic update from web-platform-tests webrtc wpt: remove test for unimplemented tlsGroup stats removed in w3c/webrtc-stats#622 (comment) BUG=None Change-Id: I8b2d8b2fa7776607bc863d6888a6ddb655dfac2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5018488 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1223532} -- wpt-commits: 8bb6ce81118b954e6af5870cbf770de3f6dee01b wpt-pr: 43104
…d tlsGroup stats, a=testonly Automatic update from web-platform-tests webrtc wpt: remove test for unimplemented tlsGroup stats removed in w3c/webrtc-stats#622 (comment) BUG=None Change-Id: I8b2d8b2fa7776607bc863d6888a6ddb655dfac2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5018488 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1223532} -- wpt-commits: 8bb6ce81118b954e6af5870cbf770de3f6dee01b wpt-pr: 43104
…d tlsGroup stats, a=testonly Automatic update from web-platform-tests webrtc wpt: remove test for unimplemented tlsGroup stats removed in w3c/webrtc-stats#622 (comment) BUG=None Change-Id: I8b2d8b2fa7776607bc863d6888a6ddb655dfac2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5018488 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1223532} -- wpt-commits: 8bb6ce81118b954e6af5870cbf770de3f6dee01b wpt-pr: 43104
…d tlsGroup stats, a=testonly Automatic update from web-platform-tests webrtc wpt: remove test for unimplemented tlsGroup stats removed in w3c/webrtc-stats#622 (comment) BUG=None Change-Id: I8b2d8b2fa7776607bc863d6888a6ddb655dfac2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5018488 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1223532} -- wpt-commits: 8bb6ce81118b954e6af5870cbf770de3f6dee01b wpt-pr: 43104
…d tlsGroup stats, a=testonly Automatic update from web-platform-tests webrtc wpt: remove test for unimplemented tlsGroup stats removed in w3c/webrtc-stats#622 (comment) BUG=None Change-Id: I8b2d8b2fa7776607bc863d6888a6ddb655dfac2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5018488 Reviewed-by: Henrik Boström <hboschromium.org> Commit-Queue: Philipp Hancke <phanckemicrosoft.com> Cr-Commit-Position: refs/heads/main{#1223532} -- wpt-commits: 8bb6ce81118b954e6af5870cbf770de3f6dee01b wpt-pr: 43104 UltraBlame original commit: 9576c917f0f49d63e5a36c4216b8d77fefa8a90c
…d tlsGroup stats, a=testonly Automatic update from web-platform-tests webrtc wpt: remove test for unimplemented tlsGroup stats removed in w3c/webrtc-stats#622 (comment) BUG=None Change-Id: I8b2d8b2fa7776607bc863d6888a6ddb655dfac2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5018488 Reviewed-by: Henrik Boström <hboschromium.org> Commit-Queue: Philipp Hancke <phanckemicrosoft.com> Cr-Commit-Position: refs/heads/main{#1223532} -- wpt-commits: 8bb6ce81118b954e6af5870cbf770de3f6dee01b wpt-pr: 43104 UltraBlame original commit: 9576c917f0f49d63e5a36c4216b8d77fefa8a90c
…d tlsGroup stats, a=testonly Automatic update from web-platform-tests webrtc wpt: remove test for unimplemented tlsGroup stats removed in w3c/webrtc-stats#622 (comment) BUG=None Change-Id: I8b2d8b2fa7776607bc863d6888a6ddb655dfac2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5018488 Reviewed-by: Henrik Boström <hboschromium.org> Commit-Queue: Philipp Hancke <phanckemicrosoft.com> Cr-Commit-Position: refs/heads/main{#1223532} -- wpt-commits: 8bb6ce81118b954e6af5870cbf770de3f6dee01b wpt-pr: 43104 UltraBlame original commit: 9576c917f0f49d63e5a36c4216b8d77fefa8a90c
One of the steps needed for #621.
The metrics removed in this PR are those not implemented according to:
Metrics are removed regardless if they are easy or hard to implement and regardless of their usefulness - this is entirely based on implementers' interest.
Everything is not covered in this PR, other stuff:
Stuff implemented but failing in the WPT:
Preview | Diff