Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add rtxSsrc to inbound-rtp and outbound-rtp stats and fecSsrc to inbound-rtp #765

Merged
merged 3 commits into from
Aug 3, 2023
Merged

add rtxSsrc to inbound-rtp and outbound-rtp stats and fecSsrc to inbound-rtp #765

merged 3 commits into from
Aug 3, 2023

Conversation

fippo
Copy link
Contributor

@fippo fippo commented Jul 20, 2023 •
edited by pr-preview bot

For RTX this was previously defined in
https://w3c.github.io/webrtc-provisional-stats/#dom-rtcoutboundrtpstreamstats-rtxssrc
(only for outbound)

For FEC it is only defined for inbound-rtp due to the lack of a sender-side implementation of flexfec (this does not apply to ulpfec which uses the same SSRC)

fixes #751 (once again)

Preview | Diff

@fippo
Copy link
Contributor Author

fippo commented Jul 20, 2023

I pledge an implementation too

@fippo fippo changed the title add rtxSsrc to inbound-rtp and outbound-rtp stats add rtxSsrc to inbound-rtp and outbound-rtp stats and fecSsrc to inbound-rtp Jul 20, 2023
@henbos
Copy link
Collaborator

henbos commented Jul 24, 2023

I pledge an implementation too

Awesome!

@alvestrand alvestrand merged commit 64a081f into w3c:main Aug 3, 2023
2 checks passed
fippo added a commit to fippo/webrtc-provisional-stats that referenced this pull request Aug 4, 2023
@fippo
Remove rtxSsrc which was moved to webrtc-stats
5733ff8 
moved in w3c/webrtc-stats#765
@fippo fippo deleted the rtxssrc branch August 4, 2023 08:52
@fippo fippo mentioned this pull request Aug 4, 2023
Merged
ibaoger pushed a commit to ibaoger/webrtc that referenced this pull request Aug 4, 2023
@fippo
stats: implement RTX ssrc on inbound-rtp/outbound-rtp
9b82b2f 
spec change:
  w3c/webrtc-stats#765

BUG=webrtc:15096

Change-Id: I7c72193c23460330b6bb612a9568641d187ee638
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/312362
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40510}
ibaoger pushed a commit to ibaoger/webrtc that referenced this pull request Aug 4, 2023
@fippo
stats: implement fecSsrc on inbound-rtp
e2e0451 
which is present if a fec mechanism like FlexFEC is negotiated

spec change:
  w3c/webrtc-stats#765

BUG=webrtc:15250

Change-Id: I7d71d49fab0153d734f22831e6684d2acfc647fb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/314981
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40514}
aarongable pushed a commit to chromium/chromium that referenced this pull request Aug 7, 2023
@fippo
webrtc: implement rtxSsrc on inbound-rtp/outbound-rtp stats
f977141 
spec change
  w3c/webrtc-stats#765

WebRTC change:
  https://webrtc-review.googlesource.com/c/src/+/312362

BUG=webrtc:15096

Change-Id: Ife0cd58fdd4d98461d646b40532c2e0bfd48bb4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4701074
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1180175}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Oct 23, 2023
@Pehrsons
Bug 1857862 - Vendor libwebrtc from 9b82b2f8d6
464b43b 
Upstream commit: https://webrtc.googlesource.com/src/+/9b82b2f8d67dd657aceca0802ff7aca36bd853a7
    stats: implement RTX ssrc on inbound-rtp/outbound-rtp

    spec change:
      w3c/webrtc-stats#765

    BUG=webrtc:15096

    Change-Id: I7c72193c23460330b6bb612a9568641d187ee638
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/312362
    Reviewed-by: Harald Alvestrand <hta@webrtc.org>
    Commit-Queue: Philipp Hancke <phancke@microsoft.com>
    Reviewed-by: Henrik Boström <hbos@webrtc.org>
    Cr-Commit-Position: refs/heads/main@{#40510}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Oct 23, 2023
@Pehrsons
Bug 1857862 - Vendor libwebrtc from e2e04513e7
bd2a3f5 
Upstream commit: https://webrtc.googlesource.com/src/+/e2e04513e7ed6a43bf854403fedf3812ac3d2991
    stats: implement fecSsrc on inbound-rtp

    which is present if a fec mechanism like FlexFEC is negotiated

    spec change:
      w3c/webrtc-stats#765

    BUG=webrtc:15250

    Change-Id: I7d71d49fab0153d734f22831e6684d2acfc647fb
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/314981
    Reviewed-by: Henrik Boström <hbos@webrtc.org>
    Commit-Queue: Philipp Hancke <phancke@microsoft.com>
    Reviewed-by: Harald Alvestrand <hta@webrtc.org>
    Cr-Commit-Position: refs/heads/main@{#40514}
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Oct 24, 2023
@Pehrsons
Bug 1857862 - Vendor libwebrtc from 9b82b2f8d6
d7ead60 
Upstream commit: https://webrtc.googlesource.com/src/+/9b82b2f8d67dd657aceca0802ff7aca36bd853a7
    stats: implement RTX ssrc on inbound-rtp/outbound-rtp

    spec change:
      w3c/webrtc-stats#765

    BUG=webrtc:15096

    Change-Id: I7c72193c23460330b6bb612a9568641d187ee638
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/312362
    Reviewed-by: Harald Alvestrand <hta@webrtc.org>
    Commit-Queue: Philipp Hancke <phancke@microsoft.com>
    Reviewed-by: Henrik Boström <hbos@webrtc.org>
    Cr-Commit-Position: refs/heads/main@{#40510}
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Oct 24, 2023
@Pehrsons
Bug 1857862 - Vendor libwebrtc from e2e04513e7
5c307df 
Upstream commit: https://webrtc.googlesource.com/src/+/e2e04513e7ed6a43bf854403fedf3812ac3d2991
    stats: implement fecSsrc on inbound-rtp

    which is present if a fec mechanism like FlexFEC is negotiated

    spec change:
      w3c/webrtc-stats#765

    BUG=webrtc:15250

    Change-Id: I7d71d49fab0153d734f22831e6684d2acfc647fb
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/314981
    Reviewed-by: Henrik Boström <hbos@webrtc.org>
    Commit-Queue: Philipp Hancke <phancke@microsoft.com>
    Reviewed-by: Harald Alvestrand <hta@webrtc.org>
    Cr-Commit-Position: refs/heads/main@{#40514}
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 30, 2023
@marco-c
Bug 1857862 - Vendor libwebrtc from 9b82b2f8d6
b4f1974 
Upstream commit: https://webrtc.googlesource.com/src/+/9b82b2f8d67dd657aceca0802ff7aca36bd853a7
    stats: implement RTX ssrc on inbound-rtp/outbound-rtp

    spec change:
      w3c/webrtc-stats#765

    BUG=webrtc:15096

    Change-Id: I7c72193c23460330b6bb612a9568641d187ee638
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/312362
    Reviewed-by: Harald Alvestrand <htawebrtc.org>
    Commit-Queue: Philipp Hancke <phanckemicrosoft.com>
    Reviewed-by: Henrik Boström <hboswebrtc.org>
    Cr-Commit-Position: refs/heads/main{#40510}

UltraBlame original commit: 6cfc14de5a61dde306f262382910f507c13891d5
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 30, 2023
@marco-c
Bug 1857862 - Vendor libwebrtc from e2e04513e7
f77cd61 
Upstream commit: https://webrtc.googlesource.com/src/+/e2e04513e7ed6a43bf854403fedf3812ac3d2991
    stats: implement fecSsrc on inbound-rtp

    which is present if a fec mechanism like FlexFEC is negotiated

    spec change:
      w3c/webrtc-stats#765

    BUG=webrtc:15250

    Change-Id: I7d71d49fab0153d734f22831e6684d2acfc647fb
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/314981
    Reviewed-by: Henrik Boström <hboswebrtc.org>
    Commit-Queue: Philipp Hancke <phanckemicrosoft.com>
    Reviewed-by: Harald Alvestrand <htawebrtc.org>
    Cr-Commit-Position: refs/heads/main{#40514}

UltraBlame original commit: ed3d6020de905a0ae8b26339c0116e521211ae39
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 30, 2023
@marco-c
Bug 1857862 - Vendor libwebrtc from 9b82b2f8d6
ad33ce1 
Upstream commit: https://webrtc.googlesource.com/src/+/9b82b2f8d67dd657aceca0802ff7aca36bd853a7
    stats: implement RTX ssrc on inbound-rtp/outbound-rtp

    spec change:
      w3c/webrtc-stats#765

    BUG=webrtc:15096

    Change-Id: I7c72193c23460330b6bb612a9568641d187ee638
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/312362
    Reviewed-by: Harald Alvestrand <htawebrtc.org>
    Commit-Queue: Philipp Hancke <phanckemicrosoft.com>
    Reviewed-by: Henrik Boström <hboswebrtc.org>
    Cr-Commit-Position: refs/heads/main{#40510}

UltraBlame original commit: 6cfc14de5a61dde306f262382910f507c13891d5
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 30, 2023
@marco-c
Bug 1857862 - Vendor libwebrtc from e2e04513e7
e064068 
Upstream commit: https://webrtc.googlesource.com/src/+/e2e04513e7ed6a43bf854403fedf3812ac3d2991
    stats: implement fecSsrc on inbound-rtp

    which is present if a fec mechanism like FlexFEC is negotiated

    spec change:
      w3c/webrtc-stats#765

    BUG=webrtc:15250

    Change-Id: I7d71d49fab0153d734f22831e6684d2acfc647fb
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/314981
    Reviewed-by: Henrik Boström <hboswebrtc.org>
    Commit-Queue: Philipp Hancke <phanckemicrosoft.com>
    Reviewed-by: Harald Alvestrand <htawebrtc.org>
    Cr-Commit-Position: refs/heads/main{#40514}

UltraBlame original commit: ed3d6020de905a0ae8b26339c0116e521211ae39
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 30, 2023
@marco-c
Bug 1857862 - Vendor libwebrtc from 9b82b2f8d6
cc240b9 
Upstream commit: https://webrtc.googlesource.com/src/+/9b82b2f8d67dd657aceca0802ff7aca36bd853a7
    stats: implement RTX ssrc on inbound-rtp/outbound-rtp

    spec change:
      w3c/webrtc-stats#765

    BUG=webrtc:15096

    Change-Id: I7c72193c23460330b6bb612a9568641d187ee638
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/312362
    Reviewed-by: Harald Alvestrand <htawebrtc.org>
    Commit-Queue: Philipp Hancke <phanckemicrosoft.com>
    Reviewed-by: Henrik Boström <hboswebrtc.org>
    Cr-Commit-Position: refs/heads/main{#40510}

UltraBlame original commit: 6cfc14de5a61dde306f262382910f507c13891d5
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 30, 2023
@marco-c
Bug 1857862 - Vendor libwebrtc from e2e04513e7
ce47646 
Upstream commit: https://webrtc.googlesource.com/src/+/e2e04513e7ed6a43bf854403fedf3812ac3d2991
    stats: implement fecSsrc on inbound-rtp

    which is present if a fec mechanism like FlexFEC is negotiated

    spec change:
      w3c/webrtc-stats#765

    BUG=webrtc:15250

    Change-Id: I7d71d49fab0153d734f22831e6684d2acfc647fb
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/314981
    Reviewed-by: Henrik Boström <hboswebrtc.org>
    Commit-Queue: Philipp Hancke <phanckemicrosoft.com>
    Reviewed-by: Harald Alvestrand <htawebrtc.org>
    Cr-Commit-Position: refs/heads/main{#40514}

UltraBlame original commit: ed3d6020de905a0ae8b26339c0116e521211ae39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henbos henbos henbos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RTX and FEC stats are incomplete.
3 participants
@fippo @henbos @alvestrand