Add "only exists" clause to various audio/video stats #774
Conversation
and add linebreaks after those clauses. Also sync definition of "mid" stat between inbound-rtp and outbound-rtp
| Only [= map/exist =]s if the {{RTCRtpTransceiver}} owning this stream has a | ||
| {{RTCRtpTransceiver/mid}} value that is not null. this is that | ||
| value. | ||
| If the {{RTCRtpTransceiver}} owning this stream has a |
There was a problem hiding this comment.
Taken from https://w3c.github.io/webrtc-stats/#dom-rtcinboundrtpstreamstats-mid
I wonder if inbound-rtp and outbound-rtp need to take care of the edge case where mid was offered but not negotiated but that seems orthogonal
There was a problem hiding this comment.
I'd update both of them to say "otherwise this member does not [= map/exist =]." so that they're consistent with each other but we also make use of the "map/exist" reference used everywhere else
There was a problem hiding this comment.
But the edge case you're describing seems orthogonal and not sure it's needed since this is just piggybacking on whatever the transceiver is doing
There was a problem hiding this comment.
I think we need to distinguish between "exist" and "present"
There was a problem hiding this comment.
But the implementation does not make such distinction. It either is there and has a string value or it is not there. We don't support null or even undefined values. If a value on a dictionary is not set, it does not [= map/exist =].
There was a problem hiding this comment.
Yeah. But I think we should only use exist for things that will never exist, not things that will not be set on some condition
There was a problem hiding this comment.
But it will never exist for that object. Every getStats call returns a new object, so we only have objects where it always existed and objects where it never existed. The continuation over time is an illusion.
There was a problem hiding this comment.
Not a hill to die on, i'm happy using the previous text as long as it is done in both locations
|
I think this is PR is great thing! But nit: while "no implementation change intended", this is not strictly "editorial" since we change from "applicable to both kinds" to "applicable to only video". |
|
But only for things which we already knew were video-only but this was not documented? |
fippo
changed the title
|
Adjusted the title, this is above "fixes whitespace" but technically a normative change. |
and add linebreaks after those clauses.
Also sync definition of "mid" stat between inbound-rtp and outbound-rtp
Preview | Diff