-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling of unknown scalability modes is underspecified #57
Comments
See w3c/webrtc-svc#57, 58, 59 for background. Bug: none Change-Id: I4bad7ee6659d01e28cc1d13e9bb595d05e512565
'TotalNonsense' isn't a valid scalabilityMode for any codec. This is an argument for |
In the SVC spec https://w3c.github.io/webrtc-svc/#error-handling:
While it doesn't apply for |
This section should probably be written in imperative language. Something like: Add to the operation of setParameters step 6: If any scalabilityMode of any encoding is not supported by any codec in parameters.codecs, reject p with a newly created Add to the operation of addTransceivers step 8: If any scalabilityMode is not supported by any codec in RTCRtpSender.getCapabilities(kind).codecs, reject p with a newly created OperationError. |
Closed after merger of PR 64. |
See w3c/webrtc-svc#57, 58, 59 for background. Bug: none Change-Id: I4bad7ee6659d01e28cc1d13e9bb595d05e512565
See w3c/webrtc-svc#57, 58, 59 for background. Bug: none Change-Id: I4bad7ee6659d01e28cc1d13e9bb595d05e512565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3369962 Reviewed-by: Florent Castelli <orphis@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/main@{#982200}
See w3c/webrtc-svc#57, 58, 59 for background. Bug: none Change-Id: I4bad7ee6659d01e28cc1d13e9bb595d05e512565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3369962 Reviewed-by: Florent Castelli <orphis@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/main@{#982200}
See w3c/webrtc-svc#57, 58, 59 for background. Bug: none Change-Id: I4bad7ee6659d01e28cc1d13e9bb595d05e512565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3369962 Reviewed-by: Florent Castelli <orphis@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/main@{#982200}
…parameters, a=testonly Automatic update from web-platform-tests Add webrtc-svc tests for error-inducing parameters See w3c/webrtc-svc#57, 58, 59 for background. Bug: none Change-Id: I4bad7ee6659d01e28cc1d13e9bb595d05e512565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3369962 Reviewed-by: Florent Castelli <orphis@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/main@{#982200} -- wpt-commits: ce1ae2d8cbd6052da722c7210fa3b7cfa78276ed wpt-pr: 32269
…parameters, a=testonly Automatic update from web-platform-tests Add webrtc-svc tests for error-inducing parameters See w3c/webrtc-svc#57, 58, 59 for background. Bug: none Change-Id: I4bad7ee6659d01e28cc1d13e9bb595d05e512565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3369962 Reviewed-by: Florent Castelli <orphis@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/main@{#982200} -- wpt-commits: ce1ae2d8cbd6052da722c7210fa3b7cfa78276ed wpt-pr: 32269
…parameters, a=testonly Automatic update from web-platform-tests Add webrtc-svc tests for error-inducing parameters See w3c/webrtc-svc#57, 58, 59 for background. Bug: none Change-Id: I4bad7ee6659d01e28cc1d13e9bb595d05e512565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3369962 Reviewed-by: Florent Castelli <orphis@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/main@{#982200} -- wpt-commits: ce1ae2d8cbd6052da722c7210fa3b7cfa78276ed wpt-pr: 32269
…parameters, a=testonly Automatic update from web-platform-tests Add webrtc-svc tests for error-inducing parameters See w3c/webrtc-svc#57, 58, 59 for background. Bug: none Change-Id: I4bad7ee6659d01e28cc1d13e9bb595d05e512565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3369962 Reviewed-by: Florent Castelli <orphis@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/main@{#982200} -- wpt-commits: ce1ae2d8cbd6052da722c7210fa3b7cfa78276ed wpt-pr: 32269
See w3c/webrtc-svc#57, 58, 59 for background. Bug: none Change-Id: I4bad7ee6659d01e28cc1d13e9bb595d05e512565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3369962 Reviewed-by: Florent Castelli <orphis@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/main@{#982200} NOKEYCHECK=True GitOrigin-RevId: 8cdb88830c8c409c52e6fde66334b33029400116
Consider the following snippet:
What should the value of encoding.scalabilityMode be?
This matters a lot for the case where "supported scalability modes" is not part of the API.
(At the moment the Chrome implementation returns 'TotalNonsense')
The text was updated successfully, but these errors were encountered: