Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify behavior of getParameters() #68

Closed
aboba opened this issue Feb 26, 2022 · 5 comments
Closed

Clarify behavior of getParameters() #68

aboba opened this issue Feb 26, 2022 · 5 comments

Comments

@aboba
Copy link
Contributor

aboba commented Feb 26, 2022

There is a need for additional clarifications on the behavior of getParameters() before and after initial negotiation, as well as during a re-negotiation. Specifically:

  • What is returned if scalabilityMode was not set.
  • What is returned if an attempt was made to set scalabilityMode, but the attempt failed.
  • What is returned if setCodecPreferences() is used to change the preferred codec.
aboba added a commit that referenced this issue Feb 26, 2022
@aboba aboba self-assigned this Feb 26, 2022
@aboba
Copy link
Contributor Author

aboba commented Mar 3, 2022

Closed by PR 69

@aboba aboba closed this as completed Mar 3, 2022
@aboba
Copy link
Contributor Author

aboba commented Mar 4, 2022

Reopening for discussion at March 15 meeting.

@aboba aboba reopened this Mar 4, 2022
@aboba
Copy link
Contributor Author

aboba commented Mar 15, 2022

March 15 meeting discussion about re-negotiation:

  • Until re-negotiation is complete, RTCRtpSender.getParameters() should return the current configuration.
  • Example: VP8 had been negotiated initially with 'L1T2', and then renegotiation begins to switch the preferred codec to H.264/AVC (with only 'L1T1' supported). Before re-negotiation completes, getParameters() returns 'L1T2'. After re-negotiation is completed, 'L1T1' is returned.
  • This appears consistent with the text on getParameters() and setParameters() in Section 5.2 RTCRtpSender Interface.

@jan-ivar Can you provide a reference to the text on [[SendEncodings]] that concerns you?

@jan-ivar
Copy link
Member

jan-ivar commented Mar 16, 2022

False alarm, sorry. The anomaly I recalled was receiver-side in w3c/webrtc-pc#2710:

IOW the set a session description algorithm ensures that:

  • the receiver returns pending encodings in "have-local-offer", whereas
  • the sender always returns current encodings

March 15 meeting discussion about re-negotiation:

  • Until re-negotiation is complete, RTCRtpSender.getParameters() should return the current configuration.

Since scalabilityMode is in sender-side encodings, this decision is congruent with the current spec (and already specified).

@aboba
Copy link
Contributor Author

aboba commented Mar 16, 2022

OK. Am going to close this issue. If there are other concerns relating to setParameters() or getParameters() behavior, please reopen.

@aboba aboba closed this as completed Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants