Update getParameters() to not return the default scalabilityMode #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always returning the current scalabilityMode has some backwards compatibility issues. Applications that need to select specific scalabilityModes will still be able to observe when a fallback happens, others could use getStats() instead. Fixes w3c#75
Orphis
force-pushed
the
remove_getparameters_no_default
branch
from
a039f7e
to
62772a4
Compare
youennf
reviewed
Jan 26, 2023
index.html
Outdated
| not satisfactory, {{RTCRtpSender/setParameters()}} can be used | ||
| to change it. | ||
| value for each encoding in <var>encodings</var> which had a value before the | ||
| initial negotation. This may be different from the values requested in |
There was a problem hiding this comment.
Suggested change
| initial negotation. This may be different from the values requested in | |
| initial negotiation. This may be different from the values requested in |
jan-ivar
reviewed
Jan 26, 2023
jan-ivar
reviewed
Jan 26, 2023
jan-ivar
approved these changes
Jan 26, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always returning the current scalabilityMode has some backwards compatibility issues. Applications that need to select specific scalabilityModes will still be able to observe when a fallback happens, others could use getStats() instead.
Fixes #75
Preview | Diff